Repository navigation
total reward counts, supressed field that are unused instead of grayi… - #3416
Open
danoswaltCL wants to merge 1 commit into
Open
danoswaltCL wants to merge 1 commit into
danoswaltCL wants to merge 1 commit into
Conversation
…ng out, non-absolute est weights
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Algorithm in Effect row still appears when warmupThreshold is 1 because the guard checks > 0 rather than the required > 1.
1 open issue
What changed in this PR
Updates the Thompson Sampling rewards card for issue #3415, making received reward counts visible and refining status and estimated-weight displays.
Changes:
- Adds per-condition received counts, including pending rewards, and displays the experiment-wide total.
- Hides inactive batching and warm-up rows instead of graying them out.
- Displays extreme estimated weights as
<1%or>99%for multi-condition experiments.
| File | Description |
|---|---|
packages/types/src/Experiment/interfaces.ts |
Adds per-condition totalRewardCount to the shared contract. |
packages/frontend/projects/upgrade/src/assets/i18n/en.json |
Adds reward-count labels and tooltips. |
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-reward-feedback-section-card/ts-configurable-reward-count-table/ts-configurable-reward-count-table.component.ts |
Registers received-count columns and formats estimated weights. |
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-reward-feedback-section-card/ts-configurable-reward-count-table/ts-configurable-reward-count-table.component.scss |
Adjusts column widths for received counts. |
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-reward-feedback-section-card/ts-configurable-reward-count-table/ts-configurable-reward-count-table.component.html |
Renders received counts and formatted weights. |
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-reward-feedback-section-card/experiment-reward-feedback-section-card.component.scss |
Removes inactive-row styling. |
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/experiment-details-page/experiment-details-page-content/experiment-reward-feedback-section-card/experiment-reward-feedback-section-card.component.html |
Conditionally hides status rows and displays total rewards. |
packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.selectors.ts |
Initializes fallback received counts to zero. |
packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.selector.spec.ts |
Updates selector expectations for the count field. |
packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.reducer.spec.ts |
Updates reward-summary fixtures. |
packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.effects.spec.ts |
Updates reward-fetch fixtures. |
packages/backend/test/unit/services/ThompsonSamplingExperimentCrudService.test.ts |
Tests per-condition counts including pending rewards. |
packages/backend/src/api/services/ThompsonSamplingExperimentCrudService.ts |
Returns applied plus pending reward counts per condition. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3415