Repository navigation
fix(sitemap): AI models missing from sitemap (numeric ids filtered out) - #495
Merged
Merged
Conversation
AIModel ids are GraphQL Int. The string-only isEntityItem filter added in d750e88 dropped every AI model, so aimodels-N.xml served an empty urlset.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/sitemap/aimodels-N.xmlserves an empty urlset on prod and dev. Prod's index listsaimodels-1.xml, but it has 0 urls while the prod backend has 15 public, active AI models.isEntityItem(added in d750e88, 2026-08-31) keeps only items whoseidis a string.TypeAIModel.idis a GraphQLInt({"id": 44}), so every AI model is dropped. Other entities return string ids and are unaffected.This is the same symptom as #455, which was put down to pagination and closed as won't-fix.
Fix
Accept
string | numberids.Verified
Ran
next devlocally against the prod backend (FEATURE_SITEMAP_BACKEND_BASE_URL=https://api.datakeep.civicdays.in/api):Fixes #455