Repository navigation
fix(site): center the landing grids, hide shouting-titles on the hack… - #34
Merged
Merged
Conversation
…ernews demo, trim the footer Signed-off-by: Julio Jimenez <julio@julioj.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ernews demo, trim the footer
What / why
Four fixes to the landing site; no compiler, rules or UDF changes.
styles.css, so.feature-grid { max-width: 940px }lost the equal-specificity tie against GridContainer's ownmax-widthand the grid spanned the full 1200px; andCardSecondaryclamps itself to 320–420px, so each card start-aligned inside its oversized cell. The cap now goes through GridContainer'smaxWidthprop (an inline custom property, immune to stylesheet order), and.feature-grid .feature-cardlifts the card clamp so each card fills its cell. The 620px media query is gone because GridContainer already collapses to one column at ≤768px. The CSS comment records the stylesheet-order trap.shouting-titlescard. It cannot run on the public playground (it needs the localclicklisp_shoutexecutable UDF) and only ever rendered a "not runnable here" badge.Demo.nonRunnableis replaced byDemo.hiddenRules, whichDemoLayoutfilters on, and the now-dead badge branch is removed fromRuleCard. The query stays inexamples/analytics/hackernews.lispand in the generated JSON; README's local-ClickHouse section still covers it and gains one clause saying UDF-dependent queries stay off the demo pages.click-uilink from the ClickHouse column. The bottom bar already credits@clickhouse/click-ui; that surviving link now opens in a new tab, as the removed one did and as every other footer link does.Verified in headless Chrome against the production build and under
vite dev: at 1400px both grids are 940px wide with 130px on each side and four equal 462px cards; one full-width column at 760px and 375px with no overflow; the hackernews page lists hype-tracker, long-words and prolific-authors; the ClickHouse footer column has three links.Not touched, pre-existing and unrelated: below ~700px the page scrolls horizontally because the Get started code pane inside the click-ui Panel does not shrink. Worth a separate fix (
width: 100%; min-width: 0on that pane).Checklist
make testandmake smokepasssite/updated if behavior or docs changed (samples insite/src/samples.tsstay verbatim)🤖 Generated with Claude Code