FileSystemWatcher in C#: retarget net10.0, drop the broken dispose pattern, IOException - #2233
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…ttern, IOException TextFileManager.Dispose() called GC.SuppressFinalize(true), which boxes a bool and suppresses nothing, and Dispose(bool) was public, so any caller could mark the instance disposed without disposing the watcher. The class owns one managed resource, so the finalizer and the Dispose(bool) overload are removed and Dispose() disposes the FileSystemWatcher directly. Also: - both projects retargeted from net6.0 to net10.0 - Create() throws IOException instead of the base Exception type - misspelled field FileUtil._dircetoryToMonitor renamed to _directoryToMonitor (TextFileManager._desposed went away with the dispose pattern) - Program.cs notes above the four file operations that the output order is not guaranteed, because the watcher raises its events on another thread - Microsoft.NET.Test.Sdk 18.10.1, xunit 2.9.3, xunit.runner.visualstudio 4.0.0, coverlet.collector 10.0.1 Build is clean and tests run 4 of 4 on SDK 10.0.302.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample update for the article "FileSystemWatcher in C#: How to Monitor File Changes" (https://code-maze.com/csharp-filesystemwatcher/). Touches only files-csharp/FileSystemWatcherExample.
Changes:
Packages, re-queried from api.nuget.org on 2026-09-23 (newest stable):
Verified locally on SDK 10.0.302, runtime .NET 10.0.10: dotnet build -c Release 0 warnings, 0 errors; dotnet test 4 passed, 0 failed; dotnet list package --vulnerable --include-transitive reports no vulnerable packages on either project.