Manchester | 26-ITP-SEP | Monsur Abdulrahman | Sprint 1 | Form-controls - #1540
Open
Monsur0001 wants to merge 11 commits into
Open
Monsur0001 wants to merge 11 commits into
Monsur0001 wants to merge 11 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Monsur0001
changed the title
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Monsur0001
changed the title
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Monsur0001
added
the
Needs Review
cjyuan
reviewed
Sep 22, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Your
form-controlsbranch is 11 commits behind CYF's main. Could you update your branch, and then update your code accordingly to ensure your implementation meets the updated spec?
Comment on lines
+47
to
+51
| <select name="color" id="color" required> | ||
| <option value="White">White</option> | ||
| <option value="Green">Green</option> | ||
| <option value="Black">Black</option> | ||
| </select> |
Contributor
There was a problem hiding this comment.
There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.
Comment on lines
+60
to
+61
| <label for="xs">XS</label> | ||
| <input type="radio" name="size" id="xs" required /> |
Contributor
There was a problem hiding this comment.
Suggestion: Use AI to explore
- Where to place the label of a radio button? Left or right? Why?
- How to decide when to use "radio" input and when to use "select" in a HTML form?
cjyuan
removed
the
Needs Review
cjyuan
added
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
Designed and styled the Form based on the acceptance criteria.