Skip to content

Manchester | ITP SEP 2026 | Taha Elmahmoudi | Sprint 1 | Form Controls #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Taha-Elmahmoudi wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Manchester | ITP SEP 2026 | Taha Elmahmoudi | Sprint 1 | Form Controls #1544

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec01d92
Fix label typo and clean up form structure in index.html
Taha-Elmahmoudi Sep 19, 2026
bcdc271
Fix label typo and restructure form elements in index.html
Taha-Elmahmoudi Sep 19, 2026
772099e
Restructure form elements and fix label typos in index.html
Taha-Elmahmoudi Sep 19, 2026
ece897d
Add size selection fieldset to form in index.html
Taha-Elmahmoudi Sep 19, 2026
6c25d04
Add size selection options to the form in index.html
Taha-Elmahmoudi Sep 19, 2026
775f697
Fix button type and clean up size selection field in index.html
Taha-Elmahmoudi Sep 19, 2026
fc45f4c
Fix input pattern for name field and update footer author name in ind…
Taha-Elmahmoudi Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,61 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->


<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<fieldset>
<legend>Customer Details</legend>
<p>
<label for="name">Name</label>
<input pattern=".*\S.*\S.*" type="text" for="name" id="name" required>
</p>

<p>
<lable>Email</lable>
<input type="email" for="email" id="email">
</p>
</fieldset>

<fieldset>
<legend>Choose a Color</legend>
<lable >Red</lable>
Comment on lines +30 to +37

@cjyuan cjyuan Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is not consistent.

Suggestion:

  • Look up the benefits of using a code formatter.
  • Install the Prettier extension for VS Code, then:
    • Use VS Code's Format Document feature to format your code.
    • Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.

Resource: Visual Studio Code - Formatting

Note: The formatter may not work correctly if your code contains syntax errors.

<input type="radio" id="Red" name="color" value="red" required>

<lable >white</lable>
<input type="radio" id="white" name="color" value="white" required>

<lable >Black</lable>
<input type="radio" id="black" name="color" value="black" required>
Comment on lines +39 to +44

@cjyuan cjyuan Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The letter case use in line 40 and 43 is not very consistent.


</fieldset>

<fieldset>
<legend>Choose a Size</legend>
<label>Size</label>
<select id="size" name="size" required>
<option value="" disabled selected>Select a Size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</fieldset>



<button type="submit">Submit</button>

</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Taha Elmahmoudi</p>
</footer>
</body>
</html>
Loading