Repository navigation
Conversation
sgabenov
marked this pull request as ready for review
November 8, 2026 23:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
Fixes #3021
The issue has not yet been triaged or accepted.
Proposed changes
A Guitar Pro import/export round trip currently drops per-note
VelocityandRelativeVelocityGPIF values. Preserve those optional fields in the note model,cloning and serialization, and read and write them in the GP importer/exporter.
The model fields retain metadata and do not change alphaTab playback, which
continues to use note dynamics.
Add a test that performs two round trips with positive and negative fractional
relative values, and update the generated serializer schema and release notes.
Validation
ec751a23, a synthetic GP archive withVelocity=100and
RelativeVelocity=2.75lost both values after import/export.Gp7Exporter.test.tspassed with two Windows CRLF snapshotstemporarily normalized to LF; the original bytes were restored after the run.
build-webpassed.8.0.427, and the generated repeated-round-trip test passed. Kotlin runtime
tests have not yet been run for this branch.
Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details
website/