Repository navigation
v1.35.1: same-name memo fields take their getter's name again; sqlite3 ^3.9.1 - #210
Merged
Merged
Conversation
…again (v1.35.1) 1.35.0 renamed private memo fields to *Cache. A field that only memoizes a public getter or method of the same name (`_origin` for `origin`) takes that name again, as in 1.34.0: 27 fields. `_requesterAddressCache` is `_requesterAddressResolved` again (a value resolved once; the getter's name is taken by the given address). Caches filled by a private helper or a differently named member keep *Cache. Private names only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sqlite3 3.9.1's build hook checks the response status of its native library download from GitHub releases: an outage (e.g. a 504) is reported as such, not as a hash mismatch (simolus3/sqlite3.dart#435). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 95.67% 95.93% +0.26%
==========================================
Files 75 75
Lines 25953 25947 -6
==========================================
+ Hits 24830 24892 +62
+ Misses 1123 1055 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.35.0 renamed private memo fields to
*Cache. This gives the old name back to a field that only memoizes a public getter or method of the same name, the way 1.34.0 had it:Reverted (28 fields, private names only, behavior unchanged):
APIRequest:_hostname,_port,_origin,_lastPathPart;_requesterAddressResolved, its 1.34.0 name. It holds one value resolved from the given address or the headers, and_requesterAddressis already the given address.EntityHandlerand its subclasses:_idType,_fieldsNames(in bothGenericEntityHandlerandClassReflectionEntityHandler),_fieldsNamesIndexes,_fieldsNamesLC,_fieldsNamesSimple,_fieldsEntityAnnotations,_fieldsWithTypeList,_fieldsWithTypeEntity,_fieldsWithTypeEntityOrReference,_fieldsWithEntityReference,_fieldsWithTypeListEntity,_fieldsWithEntityReferenceList,_constructors,_siblingsEntityHandlersEntityRulesResolver:_totalRules,_hasRuleForEntityType,_hasRuleType,_hasRuleForEntityTypeField_referenceTables,_relationshipsTables,_referenceAndRelationshipTablesDBSQLMemoryAdapter:_tablesVersions,_tablesIndexesVersionsThese keep
*Cache, because the member that fills them is private or has a different name:_directoriesStaticHandlersCache(_getDirectoryStaticHandler)_entityIndexesCache(getEntityIndexes)_fieldsEntityRepositoriesCache(_fieldsEntityRepositoriesAll)_fieldsEntityTypesCache,_fieldsEnumTypesCache,_fieldsListEntityTypesCache(getFields*Types)_fieldsTypesCache, shared bygetFieldsTypesand the subclasses'fieldsTypes_idFieldCache(getID)_literalRegExpCache(_resolveRegExp)_nonPrimitiveFieldsCache(_getNonPrimitiveFields)_responseCompressionCache(alate finalcopy ofresponseCompression)_securityCache,_securityModuleCache(filled by_security*Impl)_sharedSessionsCache(_resolveSharedSessions)Fields that 1.35.0 added (not renamed) aren't changed.
_idFieldNameCache(foridFieldName) would also fit the same-name exception; it's left as is.sqlite3: ^3.9.1(was^3.8.0). 3.9.1's build hook checks the HTTP status of its native-library download, so a GitHub release outage like today's 504s is reported as the HTTP error instead of a fake hash mismatch (simolus3/sqlite3.dart#435). The SQLite tests pass with it locally (237).Version 1.35.1:
pubspec.yaml,VERSION, CHANGELOG.dart analyze --fatal-infosis clean, and the affected tests pass (440).🤖 Generated with Claude Code