Skip to content

v1.35.1: same-name memo fields take their getter's name again; sqlite3 ^3.9.1 - #210

Merged
gmpassos merged 2 commits into
masterfrom
refactor/cache-field-names
Nov 8, 2026
Merged

gmpassos merged 2 commits into
masterfrom
refactor/cache-field-names

Conversation

@gmpassos

@gmpassos gmpassos commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

1.35.0 renamed private memo fields to *Cache. This gives the old name back to a field that only memoizes a public getter or method of the same name, the way 1.34.0 had it:

String? _origin;
String get origin => _origin ??= _originImpl();

Reverted (28 fields, private names only, behavior unchanged):

  • APIRequest: _hostname, _port, _origin, _lastPathPart; _requesterAddressResolved, its 1.34.0 name. It holds one value resolved from the given address or the headers, and _requesterAddress is already the given address.
  • EntityHandler and its subclasses: _idType, _fieldsNames (in both GenericEntityHandler and ClassReflectionEntityHandler), _fieldsNamesIndexes, _fieldsNamesLC, _fieldsNamesSimple, _fieldsEntityAnnotations, _fieldsWithTypeList, _fieldsWithTypeEntity, _fieldsWithTypeEntityOrReference, _fieldsWithEntityReference, _fieldsWithTypeListEntity, _fieldsWithEntityReferenceList, _constructors, _siblingsEntityHandlers
  • EntityRulesResolver: _totalRules, _hasRuleForEntityType, _hasRuleType, _hasRuleForEntityTypeField
  • SQL builders: _referenceTables, _relationshipsTables, _referenceAndRelationshipTables
  • DBSQLMemoryAdapter: _tablesVersions, _tablesIndexesVersions

These keep *Cache, because the member that fills them is private or has a different name:

  • _directoriesStaticHandlersCache (_getDirectoryStaticHandler)
  • _entityIndexesCache (getEntityIndexes)
  • _fieldsEntityRepositoriesCache (_fieldsEntityRepositoriesAll)
  • _fieldsEntityTypesCache, _fieldsEnumTypesCache, _fieldsListEntityTypesCache (getFields*Types)
  • _fieldsTypesCache, shared by getFieldsTypes and the subclasses' fieldsTypes
  • _idFieldCache (getID)
  • _literalRegExpCache (_resolveRegExp)
  • _nonPrimitiveFieldsCache (_getNonPrimitiveFields)
  • _responseCompressionCache (a late final copy of responseCompression)
  • _securityCache, _securityModuleCache (filled by _security*Impl)
  • _sharedSessionsCache (_resolveSharedSessions)

Fields that 1.35.0 added (not renamed) aren't changed. _idFieldNameCache (for idFieldName) would also fit the same-name exception; it's left as is.

sqlite3: ^3.9.1 (was ^3.8.0). 3.9.1's build hook checks the HTTP status of its native-library download, so a GitHub release outage like today's 504s is reported as the HTTP error instead of a fake hash mismatch (simolus3/sqlite3.dart#435). The SQLite tests pass with it locally (237).

Version 1.35.1: pubspec.yaml, VERSION, CHANGELOG. dart analyze --fatal-infos is clean, and the affected tests pass (440).

🤖 Generated with Claude Code

gmpassos and others added 2 commits November 8, 2026 18:36
…again (v1.35.1)

1.35.0 renamed private memo fields to *Cache. A field that only memoizes a
public getter or method of the same name (`_origin` for `origin`)
takes that name again, as in 1.34.0: 27 fields. `_requesterAddressCache`
is `_requesterAddressResolved` again (a value resolved once; the getter's
name is taken by the given address). Caches filled by a private helper or
a differently named member keep *Cache. Private names only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sqlite3 3.9.1's build hook checks the response status of its native
library download from GitHub releases: an outage (e.g. a 504) is reported
as such, not as a hash mismatch (simolus3/sqlite3.dart#435).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gmpassos gmpassos changed the title v1.35.1: same-name memo fields take their getter's name again v1.35.1: same-name memo fields take their getter's name again; sqlite3 ^3.9.1 Nov 8, 2026
@codecov

codecov Bot commented Nov 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.93%. Comparing base (e857f85) to head (f28ca7f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   95.67%   95.93%   +0.26%     
==========================================
  Files          75       75              
  Lines       25953    25947       -6     
==========================================
+ Hits        24830    24892      +62     
+ Misses       1123     1055      -68     
Flag Coverage Δ
unittests 95.93% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmpassos
gmpassos merged commit 19f1b41 into master Nov 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant