Skip to content

v5.0.0: Bootstrap 5 - #11

Merged
gmpassos merged 2 commits into
masterfrom
bootstrap-5-migration
Oct 7, 2026
Merged

gmpassos merged 2 commits into
masterfrom
bootstrap-5-migration

Conversation

@gmpassos

@gmpassos gmpassos commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

bones_ui_bootstrap v5.0.0 — Bootstrap 5.3.7. Bootstrap 4 maintenance continues on branch 4.x.

Reverts the revert dc224a9 (bringing back the Bootstrap 5 work from branch bootstrap-5) and ports it to the current package:web code.

Bundled libraries

Bootstrap 5.3.7 · Bootstrap Icons 1.13.1 · JQuery 3.7.1 · Moment 2.30.1 · Date Range Picker 3.1

Changes

  • Bootstrap.load(): no longer loads JQuery.
  • Bootstrap.enableTooltip(): Bootstrap 5 API (bootstrap.Tooltip.getOrCreateInstance) on [data-bs-toggle="tooltip"] only. (The bootstrap-5 branch version called a nonexistent global bootstrap.Tooltip function, so tooltips never initialized.)
  • JQuery.openWindow(): sets innerHTML, no JQuery dependency.
  • BSAccordion: Bootstrap 5 markup + root accordion class (required: it defines the --bs-accordion-* CSS variables); new flush option (accordion-flush).
  • BootstrapIcons: iconsList regenerated for 1.13.1 (+125 icons; removed a stray font entry), VERSION = '1.13.1'.
  • daterangepicker.js: re-applied the "nearest minute" patch lost in the 3.1 upgrade; kept the single-array callback patch; both documented in the file header.
  • Not taken from bootstrap-5: global dependency_validator in CI and deprecated_member_use: ignore (only needed for the old dart:html code).
  • README, example (tooltip + flush accordion) and CHANGELOG with a 4.x → 5.0.0 migration guide.

Tests (58 browser + 13 VM)

  • bones_ui_bootstrap_bs5_test.dart — Bootstrap 5 without JQuery: load, bundled JS version, CSS first, Bootstrap 5 CSS utilities, tooltips (instances, shown title, enableTooltipOnRender, old data-toggle ignored), BSAccordion (styles, click collapse/expand, Collapse API, flush computed styles, DOM/component content, item classes/styles), JQuery.openWindow.
  • Integration: bundled JQuery/Moment versions, Bootstrap 5 jQuery plugins when JQuery is present, Date Range Picker (minute rounding, cancel, ranges).
  • Unit: new accordion markup (data-bs-*, no BS4 attributes), flush, Bootstrap Icons 1.13.1.
  • VM: iconsList ⇔ lib/icons, versions consistent across code/assets/pubspec/CHANGELOG/README, no stale bundled libs, daterangepicker.js patches present, no BS4 data attributes in lib/.
  • CI: also runs dart test --platform vm.

🤖 Generated with Claude Code

gmpassos and others added 2 commits October 7, 2026 20:27
Reverts the revert dc224a9 (restoring the Bootstrap 5 work from branch
bootstrap-5) and ports it to the package:web code:

- Bootstrap 5.3.7, Bootstrap Icons 1.13.1, JQuery 3.7.1, Moment 2.30.1,
  Date Range Picker 3.1.
- Bootstrap.load: no JQuery. enableTooltip: Bootstrap 5 API, data-bs-toggle.
- JQuery.openWindow: no JQuery dependency.
- BSAccordion: Bootstrap 5 markup + `accordion` class; new `flush` option.
- BootstrapIcons: iconsList for 1.13.1.
- daterangepicker.js: re-apply the minute rounding patch; document local patches.
- Tests: Bootstrap 5 without JQuery, flush styles, tooltip, icons (VM),
  minute rounding. CI: run VM tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ion, date picker; VM consistency checks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gmpassos
gmpassos merged commit 8c6c6b7 into master Oct 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant