Repository navigation
v5.0.0: Bootstrap 5 - #11
Merged
Merged
Conversation
Reverts the revert dc224a9 (restoring the Bootstrap 5 work from branch bootstrap-5) and ports it to the package:web code: - Bootstrap 5.3.7, Bootstrap Icons 1.13.1, JQuery 3.7.1, Moment 2.30.1, Date Range Picker 3.1. - Bootstrap.load: no JQuery. enableTooltip: Bootstrap 5 API, data-bs-toggle. - JQuery.openWindow: no JQuery dependency. - BSAccordion: Bootstrap 5 markup + `accordion` class; new `flush` option. - BootstrapIcons: iconsList for 1.13.1. - daterangepicker.js: re-apply the minute rounding patch; document local patches. - Tests: Bootstrap 5 without JQuery, flush styles, tooltip, icons (VM), minute rounding. CI: run VM tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ion, date picker; VM consistency checks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bones_ui_bootstrap v5.0.0 — Bootstrap 5.3.7. Bootstrap 4 maintenance continues on branch
4.x.Reverts the revert
dc224a9(bringing back the Bootstrap 5 work from branchbootstrap-5) and ports it to the currentpackage:webcode.Bundled libraries
Bootstrap 5.3.7 · Bootstrap Icons 1.13.1 · JQuery 3.7.1 · Moment 2.30.1 · Date Range Picker 3.1
Changes
Bootstrap.load(): no longer loads JQuery.Bootstrap.enableTooltip(): Bootstrap 5 API (bootstrap.Tooltip.getOrCreateInstance) on[data-bs-toggle="tooltip"]only. (Thebootstrap-5branch version called a nonexistent globalbootstrap.Tooltipfunction, so tooltips never initialized.)JQuery.openWindow(): setsinnerHTML, no JQuery dependency.BSAccordion: Bootstrap 5 markup + rootaccordionclass (required: it defines the--bs-accordion-*CSS variables); newflushoption (accordion-flush).BootstrapIcons:iconsListregenerated for 1.13.1 (+125 icons; removed a strayfontentry),VERSION = '1.13.1'.daterangepicker.js: re-applied the "nearest minute" patch lost in the 3.1 upgrade; kept the single-array callback patch; both documented in the file header.bootstrap-5: globaldependency_validatorin CI anddeprecated_member_use: ignore(only needed for the olddart:htmlcode).Tests (58 browser + 13 VM)
bones_ui_bootstrap_bs5_test.dart— Bootstrap 5 without JQuery: load, bundled JS version, CSS first, Bootstrap 5 CSS utilities, tooltips (instances, shown title,enableTooltipOnRender, olddata-toggleignored),BSAccordion(styles, click collapse/expand,CollapseAPI,flushcomputed styles, DOM/component content, item classes/styles),JQuery.openWindow.data-bs-*, no BS4 attributes),flush, Bootstrap Icons 1.13.1.iconsList⇔lib/icons, versions consistent across code/assets/pubspec/CHANGELOG/README, no stale bundled libs,daterangepicker.jspatches present, no BS4 data attributes inlib/.dart test --platform vm.🤖 Generated with Claude Code