Repository navigation
v4.0.2: Bootstrap 4 maintenance fixes - #12
Merged
Merged
Conversation
- JQuery.openWindow: works without JQuery (innerHTML fallback). - Moment.locale: returns false instead of throwing when not loaded. - BSDateRangePicker: remove debug prints. - BootstrapIcons: remove stray `font` entry. - README: versions, 4.x note, usage example. - Tests: unloaded libraries, openWindow, VM consistency checks; CI runs VM tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap 4 maintenance release v4.0.2 (branch
4.x).JQuery.openWindow: no longer throws when JQuery isn't loaded — uses JQueryhtml()if present (unchanged behavior), otherwise falls back tobody.innerHTML.Moment.locale: returnsfalseinstead of throwing (_moment!) when Moment isn't loaded yet.BSDateRangePicker: removed debugprints (whole config on each render; selected range on each change).BootstrapIcons: removed a strayfontentry fromiconsList(getIconPath('font')returned a path to a missing file).4.xnote,package:web-style usage example.Tests (39 browser + 11 VM):
bones_ui_bootstrap_unloaded_test.dart:Moment.localeandJQuery.openWindowwith nothing loaded.JQuery.openWindowwith JQuery.iconsList⇔lib/icons, versions across code/assets/pubspec/CHANGELOG/README, no stale bundled libs,daterangepicker.jspatches present, no debug prints.dart test --platform vm.🤖 Generated with Claude Code