Repository navigation
v5.3.1: bs4-compat review fixes - #18
Merged
Merged
Conversation
- .accordion-flush: no doubled separators. - Accordion header: first header top radius; $card-cap-padding-*/$card-cap-bg. - .navbar-toggler: no focus ring only after a tap/click (:focus:not(:focus-visible)); keyboard focus keeps the Bootstrap 5 ring. - Accordion button colors follow the app $prefix. - Lists indent: padding-left: revert (browser default, 40px). - Class aliases: sr-only sr-only-focusable skip links visible on focus. - README: header line color, color modes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from the review of the Bootstrap 4 compatibility SCSS (#15), in
lib/bootstrap-5/bs4-compat:.accordion-flush: no doubled 2px separators (the restored item top border now skips flush accordions)..card-header): the first header gets the item top radius (calc(var(--bs-accordion-border-radius) - var(--bs-accordion-border-width))), so its background no longer shows square corners past the rounded item; padding/background from$card-cap-padding-y/xand$card-cap-bg(cards and accordions stay consistent when themed)..navbar-toggler: no focus ring only after a tap/click (:focus:not(:focus-visible)), as in Bootstrap 4; the keyboard focus keeps the Bootstrap 5 ring. Before,$navbar-toggler-focus-width: 0removed any focus indicator.$prefix: the accordion button colors follow an app$prefix(were hard-codedvar(--bs-link-color)).padding-left: revert(the browser default, 40px whatever the root font size; was2.5rem).sr-only sr-only-focusable) are visible when focused:.sr-onlyonly extends.visually-hidden(whose!importantkept them hidden) without.sr-only-focusable..card-headercolor (as in Bootstrap 4); the compatibility targets the light Bootstrap 4 look (no color modes) and how to opt back.Not applied: the review's "focus border color overridden" finding: in Bootstrap 5.3.8
.accordion-button:focussets no border color ($accordion-button-focus-border-coloris deprecated since 5.3.3 and unused).Checked in an app using
bs4-compat: computed styles still match its Bootstrap 4 production CSS (lists 40px; the header radius only changes transparent headers).Tests
$card-cap-*, toggler focus, app$prefix, listsrevert, skip link aliases).dart test -p vm: 33 passed.dart test -p chrome: 73 passed.dart analyze: clean.🤖 Generated with Claude Code