Skip to content

N°10148 - Remove unused my account page content - #8

Merged
steffunky merged 1 commit into
masterfrom
issue/10148_get_profiles
Oct 8, 2026
Merged

steffunky merged 1 commit into
masterfrom
issue/10148_get_profiles

Conversation

@steffunky

Copy link
Copy Markdown
Member

Base information

Question Answer
Related to a SourceForge thread / Another PR / A GitHub Issue / Combodo ticket? N°10148
Type of change? Bug fix

Symptom (bug) / Objective (enhancement)

Unused page content flags the migration audit for deprecated way to retrieve profiles

Reproduction procedure (bug)

  1. On iTop Community 3.2.4-dev
  2. With the authent-token, combodo-my-account, and combodo-my-account-user-info extensions
  3. Using a user with access to Users (e.g., Admin or Super User)
  4. Open the "My Account" page (click on your photo in the menu)
  5. Observe that the displayed data is the same as with the previous version of the extension

Proposed solution (bug and enhancement)

Remove the page content that has been migrated to combodo-my-account-user-info

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • Would a unit test be relevant and have I added it? (no, covered by a behat test)
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

@steffunky
steffunky requested review from jf-cbd and a balanced review from Copilot October 7, 2026 08:19
@steffunky steffunky self-assigned this Oct 7, 2026
@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The obsolete methods have no remaining references, and required controller functionality remains intact.

Review effort: Balanced
Findings: None

What changed in this PR

Removes obsolete My Account user/contact content now provided by combodo-my-account-user-info.

Changes:

  • Removes deprecated user/contact rendering helpers.
  • Removes the unused DBObject import.
File Description
src/​Controller/​AuthentTokenAjaxController.php Removes migrated My Account content generation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@steffunky
steffunky merged commit 636fc6b into master Oct 8, 2026
2 of 3 checks passed
@steffunky
steffunky deleted the issue/10148_get_profiles branch October 8, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants