Repository navigation
chore(deps): zip 9 in the desktop app (fixes cargo audit on main) - #208
Merged
Merged
Conversation
cargo audit fails on main for zip 8.6.0 (RUSTSEC-2026-0367, -0368, -0369, all fixed in 9.0.0). The desktop app uses zip only to unpack the ThermoRawFileParser release. zip 9 returns a Result from ZipFile::name and gives FileOptions a second lifetime; both call sites are updated. The advisories concern the crate's own extract(), which this code does not call, but unzip() had the same SUID/SGID weakness as RUSTSEC-2026-0367: it applied the archive's Unix mode as is. It now keeps the permission bits only (mode & 0o777). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo auditfails on main since #197 merged: rustls is fixed, butdesktop/Cargo.lockstill pins zip 8.6.0 (RUSTSEC-2026-0367, -0368, -0369; fixed in 9.0.0). The same failure shows on every open PR.zip8 -> 9 (9.0.4) indesktop/src-tauri/Cargo.toml; the lockfile addsnixandcfg_aliases.ZipFile::name()returns aResult, andFileOptionstakes two lifetimes. Both call sites inthermo.rsare updated.unzip()did not call the crate's vulnerableextract(), but it applied the archive's Unix mode as is, which is the SUID/SGID issue of RUSTSEC-2026-0367 in our own code. It now appliesmode & 0o777.Checked locally:
cargo test thermo(14 passed, including the traversal and round-trip unzip tests),cargo clippy --all-targets -D warnings, and the CIcargo auditcommand (only the allowedproc-macro-errorwarning remains).🤖 Generated with Claude Code