Repository navigation
fix: restore the line continuations of 28 log and error strings - #212
Merged
Merged
Conversation
28 string literals in log, warning, error and assertion messages carried a
run of 14 to 26 spaces in the middle of a sentence ("ranking by the
untrained prelim_score ..."): a `\` continuation whose
backslash and newline had been removed, leaving the space before it and the
next line's indentation. Each run is split back into ` \` + newline +
indentation, which restores the original source and the single space the
message meant. Deliberate alignment (the `\x20` padding of `mumdia doctor`,
the benchmark tables in bench_fragindex.rs) is unchanged. No behaviour
changes; rustfmt re-wrapped one expression in run.rs that the shorter line
now fits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
28 string literals in log, warning, error and assertion messages carried a run of 14 to 26 spaces in the middle of a sentence. For example, the rescore warning read:
Each was a
\line continuation whose backslash and newline had been removed, leaving the space before it and the next line's indentation. This PR splits each run back into\+ newline + indentation. That restores the original source, and the message again has the single space it meant.fdr.rs,index.rs,main.rs,sidecar.rsand the compete, convert, extract, features, quant, rescore, rt_im_train, run, run_experiment, search_seed and seed_pool stages, plus 5 assertion messages intests/pipeline.rs.\x20padding inmumdia doctoroutput and the benchmark tables intests/bench_fragindex.rs.run.rsshows a large diff, but it is whitespace only (git diff -whas 5 changed lines). With the over-long string gone, rustfmt can format the enclosinglet ... = if cfg.groups.window_groups > 1 {expression it had skipped.scripts/.Checked:
cargo fmt --check, clippy-D warnings, workspace tests.🤖 Generated with Claude Code