Skip to content

fix: restore the line continuations of 28 log and error strings - #212

Merged
RobbinBouwmeester merged 2 commits into
mainfrom
fix/log-string-spaces
Oct 18, 2026
Merged

RobbinBouwmeester merged 2 commits into
mainfrom
fix/log-string-spaces

Conversation

@RobbinBouwmeester

Copy link
Copy Markdown
Member

28 string literals in log, warning, error and assertion messages carried a run of 14 to 26 spaces in the middle of a sentence. For example, the rescore warning read:

rescore: too few decoys to train a classifier; ranking by the untrained              prelim_score with plain target-decoy competition

Each was a \ line continuation whose backslash and newline had been removed, leaving the space before it and the next line's indentation. This PR splits each run back into \ + newline + indentation. That restores the original source, and the message again has the single space it meant.

  • 16 files: fdr.rs, index.rs, main.rs, sidecar.rs and the compete, convert, extract, features, quant, rescore, rt_im_train, run, run_experiment, search_seed and seed_pool stages, plus 5 assertion messages in tests/pipeline.rs.
  • Deliberate alignment is unchanged: the \x20 padding in mumdia doctor output and the benchmark tables in tests/bench_fragindex.rs.
  • run.rs shows a large diff, but it is whitespace only (git diff -w has 5 changed lines). With the over-long string gone, rustfmt can format the enclosing let ... = if cfg.groups.window_groups > 1 { expression it had skipped.
  • No behaviour changes. A scan for the same pattern finds none left in the Rust sources and none in scripts/.

Checked: cargo fmt --check, clippy -D warnings, workspace tests.

🤖 Generated with Claude Code

RobbinBouwmeester and others added 2 commits October 18, 2026 11:38
28 string literals in log, warning, error and assertion messages carried a
run of 14 to 26 spaces in the middle of a sentence ("ranking by the
untrained              prelim_score ..."): a `\` continuation whose
backslash and newline had been removed, leaving the space before it and the
next line's indentation. Each run is split back into ` \` + newline +
indentation, which restores the original source and the single space the
message meant. Deliberate alignment (the `\x20` padding of `mumdia doctor`,
the benchmark tables in bench_fragindex.rs) is unchanged. No behaviour
changes; rustfmt re-wrapped one expression in run.rs that the shorter line
now fits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RobbinBouwmeester
RobbinBouwmeester merged commit efdbfbc into main Oct 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant