Repository navigation
refactor(configuration): drop the decoders ImportHandler carried and nothing called - #6009
Merged
Merged
Conversation
…nothing called decode, getJSONfromFile, getJSONfromURL and getJSONfromBody were public, but nothing in openregister or the fleet calls them on ImportHandler: UploadHandler and FetchHandler hold the live copies. The HTTP client and the upload handler were only there for them, so both leave the constructor. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 640/640 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 34638/34639 · 18 skipped | ||||
| Newman | ❌ 1628/1630 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-06 18:58 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode,getJSONfromFile,getJSONfromURLandgetJSONfromBodyonImportHandlerhad no caller. Upload and fetch run throughUploadHandlerandFetchHandler, which hold their own copies. The HTTP client and the upload handler were in the constructor only for these methods, so they leave too.Evidence the code is unused:
ImportHandlerin lib, routes or templates; onlyImportHandlerTestcalled them, and those 21 tests go with the methods.FetchHandlerTestandUploadHandlerTeststill cover the live copies.getJSONfrom*outside openregister and no call of these methods on anImportHandler. Fleet references to the class are comments.ensureArrayStructurestays: the import itself uses it.Numbers:
ImportHandlerunits over the bar 110 to 108, 1 duplicate block gone. Params 3+ unchanged.What ran on fbd6e13: all 60 import and configuration test files, 472 tests, 0 failures, 1 skipped. phpcs, phpmd, phpstan and psalm on the touched lib files, rc 0. Gate 122 ratchet: 0 findings on changed units, 17 inherited. The full suite goes through the batch.