Repository navigation
fix: sign and publish releases the way gitops-reverser does - #39
Merged
sunib merged 2 commits intoOct 5, 2026
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The 0.1.0 release pushed the chart but failed at its provenance attestation: "No credentials found for registry ghcr.io". helm logged in inside the CI container, while the attestation is pushed from the runner, which had no login. The chart job now logs in on the runner too, as the image job does. As gitops-reverser does, the job also pushes charts/artifacthub-repo.yml under the chart repository's artifacthub.io tag with oras, which is added to the ci stage of the devcontainer image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Align the release pipeline with gitops-reverser's, where it was tuned: - CI runs before release-please, so a red commit never gets a release. - Releases are drafts until every asset is attached, then publish-release publishes them; the repository has immutable releases switched on, so a published release accepts no assets. release-please-pr opens the next release pull request against the published release. - The image is signed with cosign, attested (provenance and SPDX SBOM), and the SBOM goes on the release with its signature and provenance. - The chart is signed with cosign instead of attested, which also removes the attestation step the 0.1.0 release failed on. cosign comes from the CI image, beside oras. - The release notes show how to install and verify. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sunib
force-pushed
the
ci/publish-chart-artifacthub
branch
from
October 5, 2026 16:12
d7036cb to
41ba9a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #37; retarget to
mainonce that merges.Why the 0.1.0 release failed
publish the Helm chartpushedghcr.io/configbutler/charts/krm-foyer:0.1.0, thenactions/attest-build-provenance(push-to-registry: true) failed withNo credentials found for registry ghcr.io: helm had logged in inside the CI container,and the attestation runs on the runner, which had no login.
What changes: the release pipeline follows gitops-reverser's
release accepts no assets. release-please creates a draft (
draft: true), the publishjobs attach to it,
publish-releasepublishes it last, andrelease-please-propensthe next release PR against the published release.
goes on the release with its
.sigstore.jsonand.intoto.jsonl(Scorecard'sSigned-Releases check). Release notes show how to install and verify.
removes the step 0.1.0 failed on. Each tool logs in for itself.
charts/artifacthub-repo.ymlpushed with oras under theartifacthub.iotag. NorepositoryIDyet; it comes from the Artifact Hub control panel.cistage, each checked against itsrelease's checksum file; the CI tool check runs both.
Deliberate differences from gitops-reverser: the image is built in the release job (amd64
only, and krm-foyer's CI does not push), and each chart step docker-runs the CI image,
which is a workflow artifact rather than a registry image, so
container:is not available.Verified
task verifypasses; thecistage builds with cosign v3.1.3 and oras 1.3.4.oras pushran against a localregistry:2; the manifest has Artifact Hub's configand layer media types.
🤖 Generated with Claude Code