fix 5975 by fixing api - #5977
Merged
Merged
Conversation
This PR fixes a defect in the Units API that caused DFHack#5975. The `isCitizen` and `isResident` filters would include dead units when `include_insane` was requested, which is incorrect behavior. API corrected. In addition to fixing the headline defect in `stressicons`, this also fixes latent bugs in `preserve-rooms` and in `sort` (for the "stress" sort option). `full-heal` requires an adjustment because that tool can explicitly be used on dead citizens. FIxes DFHack#5975. A collateral change in `scripts` will address the regression in `full-heal` caused by this API update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a defect in the Units API that caused #5975. The
isCitizenandisResidentfilters would include dead units wheninclude_insanewas requested, which is incorrect behavior. API corrected.In addition to fixing the headline defect in
stressicons, this also fixes latent bugs inpreserve-roomsand insort(for the "stress" sort option).full-healrequires an adjustment because that tool can explicitly be used on dead citizens.FIxes #5975. A collateral change in
scriptswill address the regression infull-healcaused by this API update