Repository navigation
Loosen the goldens tolerance for deterministic cases to 5e-6 - #7
Merged
Merged
Conversation
ubuntu-26.04 runners differ from the goldens by up to ~2e-6 on array_s2_overlap0_logits_tiny0, failing the weekly slow tier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly slow tier failed last night (run 43738950785) because of one golden case:
test_goldens_reproduce_with_ocm, casearray_s2_overlap0_logits_tiny0:outputatol=1e-6, by at most 1.9e-6The archive repo's slow tier failed the same way on 8 November (by up to 2.1e-6). Both runs used
ubuntu-26.04runners. The goldens were generated on a local CPU with torch 2.14.1.This PR raises the tolerance for deterministic cases from 1e-6 to 5e-6. Cases that aren't deterministic keep 1e-5, and class outputs are still compared exactly.
A manually triggered run that includes the slow tier passed on this branch: run 43790201601.
🤖 Generated with Claude Code