Repository navigation
Self-update: correct version message, untracked files no longer block - #15
Merged
Merged
Conversation
The version shown after darknode update / /update apply was read with a regex that matched its own source line, so it printed garbage (updated v2.46.3 -> v([^ ...). Read package.json instead.
npm install after an update created an untracked package-lock.json, and the dirty check counted untracked files, so every later update stopped with 'you have local changes'. Only tracked edits block now, and the post-update npm install no longer writes a lockfile.
Darknode-Official
force-pushed
the
fix/update-version-msg
branch
from
November 2, 2026 18:03
a163d32 to
60c7219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking every update path.
darknode update//update applythe message readupdated v2.46.3 → v([^ —because the version regex matched its own source line. It now reads package.json.Verified end to end against a local remote: fresh clone, untracked package-lock.json present, a newer commit pushed;
darknode updatefast-forwarded and printedupdated v2.46.3 → v2.46.5.