Repository navigation
Audit fixes: serve crash, Google login CSRF, sysinfo injection, Windows update, engine path - #16
Merged
Merged
Conversation
…ws update, engine path - darknode serve: an unreadable file or folder threw EACCES with no handler and killed the server. Now answers 403 and keeps serving. - darknode login google: the loopback listener took any ?code=, so any local process or page could sign the user in as another account. Adds state + PKCE (S256) and serves the error page as text/plain. - sysinfo tool: df ran through a shell with the cwd in double quotes, so $(...) or backticks in a folder name executed. Uses execFileSync. - update on Windows: spawn cannot run npm.cmd without a shell, so the npm check/install always failed. Uses npm.cmd with shell on win32. - engine sync: "/js/../../x" escaped the engines cache dir. Rejected.
… test uses a stand-in Ollama
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit fixes: serve crash, Google login CSRF, sysinfo injection, Windows update, engine path
handler and killed the server. Now answers 403 and keeps serving.
local process or page could sign the user in as another account. Adds
state + PKCE (S256) and serves the error page as text/plain.
$(...) or backticks in a folder name executed. Uses execFileSync.
npm check/install always failed. Uses npm.cmd with shell on win32.