fix: pow and daysBetween are not commutative - #232
Merged
Merged
Conversation
Member
|
This is a really sad kind of Boolean blindness. Maybe we should make a small type that encodes this and makes it easier to reason locally about each of these definitions. |
Member
|
Can you file that as a follow up issue? |
Contributor
Author
sure, no problem. |
Contributor
Author
|
Filed as #234. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize reorders the operands of commutative operations by expression key. pow and daysBetween were flagged commutative, so pow (x + 1) 2 could run as 2 ^ (x + 1), and the sign of daysBetween followed the column names. Both are now flagged not commutative. The daysBetween example in the docs relied on the swap and now passes the deadline first.
Before, with x = [2, 4]:
After:
With start = 2024-03-01 and end = 2024-03-10, daysBetween start end gave 9 and now gives -9. daysBetween end start gives 9 in both.