fix: keep nulls in nullable int32 and int64 decimal parquet columns - #233
Merged
Merged
Conversation
Member
|
Great catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DECIMAL conversion for INT32 and INT64 columns took the raw values with toVector and rebuilt the column without its null bitmap, so nulls read as 0.0 and the column was no longer nullable. It now maps the column with mapColumn, which keeps the bitmap, as the timestamp branch does. The new fixture was written by pyarrow 24.0.0 with store_decimal_as_integer=True.
Before:
After: