Repository navigation
feat: validate sketch family calls and report dialect compatibility - #2749
Open
betodealmeida wants to merge 4 commits into
Open
betodealmeida wants to merge 4 commits into
betodealmeida wants to merge 4 commits into
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Member
Author
|
@greptile-apps please review kthxbye! |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryAdds sketch-family call checks and shared dialect compatibility metadata.
|
betodealmeida
marked this pull request as ready for review
November 20, 2026 18:33
shangyian
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make sketch-family compatibility metadata reflect whether the entire metric can actually decompose. Share the check between REST and GraphQL, enforce declared output dialects, and validate aggregate calls before DISTINCT or other fallback paths can bypass validation.
Treat unsupported stored sketch parameters as a non-match, and return actionable errors for malformed stored reaggregation declarations.
Test Plan
Deployment Plan
No database migration required. Release an OSS server version containing these hooks before updating and deploying the Netflix t-digest implementation in
mp-nflx-dj. Downstream implementations opt into the validation and dialect capabilities; existing decompositions retain their defaults.