Repository navigation
Fix resampling when records exist preceding the simulation period - #1953
Merged
Merged
Conversation
|
4 of 7 tasks
JoerivanEngelen
approved these changes
Nov 3, 2026
JoerivanEngelen
left a comment
JoerivanEngelen
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with this, as this stuff is now only used to mimic iMOD5. However, if I recall correctly, I made the conscious decision to forward fill rates before the first time step of the simulation period (as that is what I would expect). We could later add some settings to let users tweak behavior somewhat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1952
Description
Fixed bug where if a record exists before the simulation period, it isn't dropped and is taken into the period mean. This wasn't caught by the tests because there wasn't a test with varying rates, so the mean was the same in any case. I added a test to catch it now.
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes