Repository navigation
Don't publish when the inventory job fails - #52
Conversation
The success job only depended on build. When inventory failed, build was skipped, which the failure/cancelled check didn't catch, so success went on to publish an unbuilt flake. Depend on both jobs and require each to have succeeded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Declare dependencies and validate results .github/workflows/workflow.yml |
The success job now depends on inventory and build. Its guard reports both results and exits when either result is not success. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: grahamc
Merge Risk: 
b421e
-
Publishing is now blocked unless both inventory and build succeed, so no merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Title check The title "Don't publish when the inventory job fails" matches the main change. The workflow's success job now depends on both inventory and build, and it fails unless both succeed, which blocks the f… Description check The description covers the problem, the cause, and the fix. It explains that the success job only had needs: build and checked for failure/cancelled, so when inventory failed, build was skipped and su… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "Don't publish when the inventory job fails" matches the main change. The workflow's success job now depends on both inventory and build, and it fails unless both succeed, which blocks the flakehub-push publish step when inventory fails. The title is specific and describes the primary behavior change from the developer's perspective.
Full details: Description check
-
Explanation
The description covers the problem, the cause, and the fix. It explains that the success job only had needs: build and checked for failure/cancelled, so when inventory failed, build was skipped and success still ran flakehub-push on the default branch or a tag. It states the fix: success depends on both inventory and build and fails unless both are success. The repository template only asks for prettier formatting before committing, and the description does not conflict with that. The description is mostly complete and clear.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
The
successjob only hadneeds: buildand failed onfailure/cancelled. Ifinventoryfailed,buildwas skipped, so neither check matched andsuccesswent on to runflakehub-push(on the default branch or a tag) for a flake that was never built.This makes
successdepend on bothinventoryandbuild, and fail unless both aresuccess.🤖 Generated with Claude Code
Summary by CodeRabbit