Skip to content

feat(ui): integrate verified Figma parity updates - #632

Merged
jjoonleo merged 21 commits into
mainfrom
feature/integrate-ios-ui-quality
Sep 25, 2026
Merged

jjoonleo merged 21 commits into
mainfrom
feature/integrate-ios-ui-quality

Conversation

@jjoonleo

Copy link
Copy Markdown
Contributor

Problem and resulting behavior

The Figma parity work in #596 was based on an older application snapshot and conflicted with the verified restore, recurrence, scheduling, and notification changes now on main. This PR carries forward the compatible iOS UI polish, assets, source-to-code mapping, and review evidence while preserving the current audited data and runtime ownership model.

The result aligns onboarding, calendar, schedule/preparation forms, recurring schedule surfaces, My Page, privacy/recovery, dialogs, and the active alarm screen with the reviewed Figma states. It also adds a reproducible strict Figma inventory check to CI.

Integration decisions

  • Preserved the current local-only data boundary, backup/restore stream ports, native iOS export/import plugins, recurrence engine, scheduling ownership, and notification lifecycle from fix: 검증 완료된 복원·시간대·일정·알림 개선 반영 #631.
  • Integrated compatible production UI and asset changes from feat(ui): complete Figma app-state review and fix iOS backup flow #596.
  • Kept the reviewed Figma source images, node mapping, parity reports, and native-device evidence.
  • Excluded the obsolete backup picker implementation and older tests that targeted APIs replaced by the audited implementations.
  • Made the CI inventory check validate all routes, variants, tracked Figma hashes, and declared golden paths. Generated Flutter golden files remain local review artifacts and are intentionally not required to exist in a clean GitHub runner.

Validation

  • flutter analyze --no-pub — passed with no issues.
  • dart run tool/check_local_only_boundary.dart — passed.
  • dart run tool/report_figma_ui_coverage.dart --strict --allow-missing-goldens — passed: 21 routes; 16 reviewed, 5 excluded; 57 variants reviewed, 1 excluded; 11 documented design-only states.
  • Focused current UI test directories — 83 tests passed.
  • Full test suite on the shared audited base — 2,013 passed, 83 skipped, 0 failed.
  • flutter build ipa --release --export-method app-store — passed; exported club.devkor.ontime.ios version 1.1.0 build 57 with Apple Distribution signing.

Closes #596 by superseding its conflicting implementation with this reviewed integration.

@jjoonleo
jjoonleo merged commit a45488a into main Sep 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant