Skip to content

chore(registry): pin spec-kit 2f7462a, the client contract for SDK 0.2 - #299

Merged
jm-rivera merged 3 commits into
devfrom
chore/spec-kit-pins-sdk-0.2
Nov 14, 2026
Merged

jm-rivera merged 3 commits into
devfrom
chore/spec-kit-pins-sdk-0.2

Conversation

@jm-rivera

@jm-rivera jm-rivera commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Moves all nine spec-kit pins to 2f7462a, the head of DevelopmentFinanceObservatory/spec-kit#52, whose client contract is recorded against dev at aacbe6a (#303).

Part of DevelopmentFinanceObservatory/sdk#19

Changes

  • pyproject.toml (dfo-spec-kit, dfo-spec-kit-client-contract), packages/dfo-data-tools/pyproject.toml (five) and packages/dfo-analysis-engine/pyproject.toml (two): rev moves from a67acbe to 2f7462a, and the pin comment names what the new client contract adds.
  • uv.lock: relocked.
  • tests/contract/test_client_contract.py: test_the_role_keys_columns_are_the_role_axes holds the client contract's rules/role-keys.json columns equal to dfo_platform.roles.ROLE_AXES, so the clients' column-to-role-key table cannot drift from the server's.

Notes for reviewers

  • Merge spec-kit#52 first. It merges with a merge commit, so 2f7462a stays in spec-kit's dev history and this pin needs no second move.
  • The new contract's scenarios post party_totals: false, expect licence* members, and type party-totals entries with kept_in, which tests/contract checks against this app's OpenAPI.

Testing: just check with spec-kit at 2f7462a (46,689 passed, 167 skipped, 7 xfailed); pytest tests/contract (121 passed). The new test fails when a key is added to, changed in or removed from either table.

…2 recorded at 133262c

Moves all nine spec-kit pins to 7ef7f71. Its client contract adds the
timeout-and-retries rule, the dfo cache root with legacy readerkit
reads, the fetched/ cache entry, the FormatError and BundleError client
codes, the party_totals_left_out outcome and the saved-file schema,
takes party_totals: false as the request spelling of the cut, and is
recorded against dev at 133262c.
The client contract now names the frame party columns of each role
key. A contract test holds that table equal to ROLE_AXES.
The spec-kit pin comment named 133262c and d80df9f as the recording
commits; the client contract at 2f7462a is recorded at aacbe6a. The
contract test's docstring now lists the role-keys check.
@jm-rivera jm-rivera changed the title chore(registry): pin spec-kit 7ef7f71, the client contract for SDK 0.2 chore(registry): pin spec-kit 2f7462a, the client contract for SDK 0.2 Nov 14, 2026
@jm-rivera
jm-rivera merged commit c9f3a0c into dev Nov 14, 2026
20 of 26 checks passed
@jm-rivera
jm-rivera deleted the chore/spec-kit-pins-sdk-0.2 branch November 14, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant