Repository navigation
chore(registry): pin spec-kit 2f7462a, the client contract for SDK 0.2 - #299
Merged
Merged
Conversation
…2 recorded at 133262c Moves all nine spec-kit pins to 7ef7f71. Its client contract adds the timeout-and-retries rule, the dfo cache root with legacy readerkit reads, the fetched/ cache entry, the FormatError and BundleError client codes, the party_totals_left_out outcome and the saved-file schema, takes party_totals: false as the request spelling of the cut, and is recorded against dev at 133262c.
The client contract now names the frame party columns of each role key. A contract test holds that table equal to ROLE_AXES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all nine spec-kit pins to 2f7462a, the head of DevelopmentFinanceObservatory/spec-kit#52, whose client contract is recorded against dev at aacbe6a (#303).
Part of DevelopmentFinanceObservatory/sdk#19
Changes
pyproject.toml(dfo-spec-kit,dfo-spec-kit-client-contract),packages/dfo-data-tools/pyproject.toml(five) andpackages/dfo-analysis-engine/pyproject.toml(two):revmoves from a67acbe to 2f7462a, and the pin comment names what the new client contract adds.uv.lock: relocked.tests/contract/test_client_contract.py:test_the_role_keys_columns_are_the_role_axesholds the client contract'srules/role-keys.jsoncolumnsequal todfo_platform.roles.ROLE_AXES, so the clients' column-to-role-key table cannot drift from the server's.Notes for reviewers
party_totals: false, expectlicence*members, and type party-totals entries withkept_in, whichtests/contractchecks against this app's OpenAPI.Testing:
just checkwith spec-kit at 2f7462a (46,689 passed, 167 skipped, 7 xfailed);pytest tests/contract(121 passed). The new test fails when a key is added to, changed in or removed from either table.