Skip to content

feat(website): mount ADMIN_EMAILS from Secret Manager - #150

Open
sefk wants to merge 1 commit into
devfrom
feat/website-admin-emails
Open

sefk wants to merge 1 commit into
devfrom
feat/website-admin-emails

Conversation

@sefk

@sefk sefk commented Nov 16, 2026

Copy link
Copy Markdown

Summary

  • Follows the pattern of feedback_webhook.tf. New admin_emails.tf creates the secret ${local.website_name}-admin-emails (dfo-dev-website-staging-admin-emails in dev, dfo-prod-website-admin-emails in prod) with a placeholder first version, the literal none.
  • none is not an email address, so the placeholder admits nobody. The website splits ADMIN_EMAILS on commas and compares each entry with a signed-in user's verified email, so /admin/api-keys answers 404 until the real list is added.
  • main.tf mounts the secret as ADMIN_EMAILS, reading latest, and waits for the placeholder version through readiness_dependencies, as for the Turnstile secret.
  • The cloud-run-service module already grants the runtime service account roles/secretmanager.secretAccessor on every secret in secret_env_vars, so no extra IAM is needed.
  • Documents adding and changing the list in the dev and prod website READMEs, with placeholder emails only. Each env.auto.tfvars carries a TODO(jorge) on who else should be an admin.

Why Secret Manager

The admin page is open only to signed-in users whose verified email is in ADMIN_EMAILS. This repository is public and so are its tfvars, so the list cannot live in Terraform. Terraform owns the secret container, the placeholder and the mount, and the real list is a version added by hand. Later versions never touch Terraform state, since the placeholder is a separate version resource. Changing the list needs a new secret version and a new Cloud Run revision, with no infra change.

Manual steps, in order

  1. Apply. This creates the secret with the none placeholder and mounts it. Nothing changes for visitors: nobody is an admin.

  2. Add the real list as a new version holding every admin (placeholder emails shown):

    printf '%s' 'a@example.org,b@example.org' | gcloud secrets versions add dfo-dev-website-staging-admin-emails \
      --project dev-fin-observatory --data-file=-
    printf '%s' 'a@example.org,b@example.org' | gcloud secrets versions add dfo-prod-website-admin-emails \
      --project prod-fin-observatory --data-file=-
    
  3. Roll a new revision, since running instances keep the value they started with: re-run the website's deploy.yml on dev for staging, or deploy-prod.yml on main for prod.

To change the list later, repeat steps 2 and 3.

Validation

  • terraform fmt -recursive infra: no changes.
  • terraform init -backend=false && terraform validate in infra/dfo-dev/website and infra/dfo-prod/website: both valid.
  • pre-commit run on the changed files (trailing whitespace, EOF, codespell, mdformat, detect-private-key): passed.
  • No terraform plan was run, since it needs the team's Google Cloud credentials.

Coordination

Part of DevelopmentFinanceObservatory/website#142, needed for website #143's admin page. Who the admins are is decided outside this repository; the secret holds the list.

🤖 Generated with Claude Code

https://claude.ai/code/session_015QQk2mKJZzXv2AYykDjvQf

The stack owns the secret <website name>-admin-emails with a placeholder
first version, `none`, which is not an email address and so admits nobody
(/admin/api-keys answers 404). The service mounts it as ADMIN_EMAILS at
latest, and the cloud-run-service module grants the runtime service
account secretAccessor on it. The real list is private, so it is added
out-of-band as a new version, as for the feedback webhook; changing it
needs a new version and a new revision, no Terraform change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QQk2mKJZzXv2AYykDjvQf
@github-actions

Copy link
Copy Markdown

Terraform Plan — website

Plan: 3 to add, 1 to change, 0 to destroy.

Init Validate Plan
pass pass pass
Show plan
ephemeral.random_password.website_better_auth_secret: Opening...
ephemeral.random_password.website_better_auth_secret: Opening complete after 0s
module.website_service.google_service_account.runtime: Refreshing state... [id=projects/dev-fin-observatory/serviceAccounts/dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
data.google_secret_manager_secret.sign_in["google-client-id"]: Reading...
data.google_secret_manager_secret.mcp_api_token: Reading...
data.google_secret_manager_secret.sign_in["microsoft-client-secret"]: Reading...
data.google_secret_manager_secret.studio_api_token: Reading...
data.google_secret_manager_secret.sign_in["microsoft-client-id"]: Reading...
data.google_secret_manager_secret.sign_in["github-client-id"]: Reading...
data.google_secret_manager_secret.sign_in["github-client-secret"]: Reading...
data.google_secret_manager_secret.sign_in["google-client-secret"]: Reading...
google_service_account.website_migrator: Refreshing state... [id=projects/dev-fin-observatory/serviceAccounts/dfo-dev-website-stg-migrator@dev-fin-observatory.iam.gserviceaccount.com]
data.google_secret_manager_secret.sign_in["google-client-secret"]: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-google-client-secret]
google_sql_database.website: Refreshing state... [id=projects/dev-fin-observatory/instances/dfo-dev-platform-postgres/databases/website-staging]
data.google_secret_manager_secret.sign_in["google-client-id"]: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-google-client-id]
google_project_iam_custom_role.cloudsql_login_only: Refreshing state... [id=projects/dev-fin-observatory/roles/dfoDevWebsiteCloudsqlLoginOnly]
data.google_secret_manager_secret.mcp_api_token: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-mcp-api-token]
data.google_secret_manager_secret.sign_in["github-client-id"]: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-github-client-id]
data.google_secret_manager_secret.sign_in["microsoft-client-secret"]: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-microsoft-client-secret]
google_secret_manager_secret.website_feedback_slack_webhook: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-feedback-slack-webhook]
data.google_secret_manager_secret.sign_in["github-client-secret"]: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-github-client-secret]
data.google_service_account.website_deployer: Reading...
data.google_secret_manager_secret.sign_in["microsoft-client-id"]: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-microsoft-client-id]
data.google_secret_manager_secret.studio_api_token: Read complete after 0s [id=projects/dev-fin-observatory/secrets/dfo-dev-studio-api-token]
google_service_account.website_export: Refreshing state... [id=projects/dev-fin-observatory/serviceAccounts/dfo-dev-website-stg-export@dev-fin-observatory.iam.gserviceaccount.com]
google_project_service.apis["compute.googleapis.com"]: Refreshing state... [id=dev-fin-observatory/compute.googleapis.com]
google_project_service.apis["dns.googleapis.com"]: Refreshing state... [id=dev-fin-observatory/dns.googleapis.com]
google_secret_manager_secret.website_turnstile_secret_key: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-turnstile-secret-key]
google_secret_manager_secret.website_better_auth_secret: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-better-auth-secret]
google_project_iam_member.website_migrator_cloudsql_client: Refreshing state... [id=dev-fin-observatory/roles/cloudsql.client/serviceAccount:dfo-dev-website-stg-migrator@dev-fin-observatory.iam.gserviceaccount.com]
google_sql_user.website_migrator: Refreshing state... [id=dfo-dev-website-stg-migrator@dev-fin-observatory.iam//dfo-dev-platform-postgres]
google_secret_manager_secret_version.website_better_auth_secret: Refreshing state... [id=projects/41292283861/secrets/dfo-dev-website-staging-better-auth-secret/versions/1]
google_secret_manager_secret_version.website_feedback_slack_webhook_placeholder: Refreshing state... [id=projects/41292283861/secrets/dfo-dev-website-staging-feedback-slack-webhook/versions/1]
data.google_service_account.website_deployer: Read complete after 0s [id=projects/dev-fin-observatory/serviceAccounts/dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com]
google_secret_manager_secret_version.website_turnstile_secret_key_placeholder: Refreshing state... [id=projects/41292283861/secrets/dfo-dev-website-staging-turnstile-secret-key/versions/1]
google_cloud_run_v2_service_iam_member.website_apis_invoker: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/services/dfo-dev-apis/roles/run.invoker/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
google_sql_user.website_runtime: Refreshing state... [id=dfo-dev-website-staging-run@dev-fin-observatory.iam//dfo-dev-platform-postgres]
google_service_account_iam_member.website_migrator_deployer_act_as: Refreshing state... [id=projects/dev-fin-observatory/serviceAccounts/dfo-dev-website-stg-migrator@dev-fin-observatory.iam.gserviceaccount.com/roles/iam.serviceAccountUser/serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com]
google_sql_user.website_export: Refreshing state... [id=dfo-dev-website-stg-export@dev-fin-observatory.iam//dfo-dev-platform-postgres]
google_project_iam_member.website_export_cloudsql_client: Refreshing state... [id=dev-fin-observatory/roles/cloudsql.client/serviceAccount:dfo-dev-website-stg-export@dev-fin-observatory.iam.gserviceaccount.com]
google_project_iam_member.website_cloudsql_client: Refreshing state... [id=dev-fin-observatory/roles/cloudsql.client/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
google_secret_manager_secret_iam_member.website_share_import_principal_access: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-share-import-principal/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_service_account_iam_member.deployer_act_as["serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com"]: Refreshing state... [id=projects/dev-fin-observatory/serviceAccounts/dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com/roles/iam.serviceAccountUser/serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com]
google_project_iam_member.website_migrator_cloudsql_login: Refreshing state... [id=dev-fin-observatory/projects/dev-fin-observatory/roles/dfoDevWebsiteCloudsqlLoginOnly/serviceAccount:dfo-dev-website-stg-migrator@dev-fin-observatory.iam.gserviceaccount.com]
google_project_iam_member.website_cloudsql_login: Refreshing state... [id=dev-fin-observatory/projects/dev-fin-observatory/roles/dfoDevWebsiteCloudsqlLoginOnly/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
google_project_iam_member.website_export_cloudsql_login: Refreshing state... [id=dev-fin-observatory/projects/dev-fin-observatory/roles/dfoDevWebsiteCloudsqlLoginOnly/serviceAccount:dfo-dev-website-stg-export@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-live-refresh-principal"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-live-refresh-principal/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-feedback-slack-webhook"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-feedback-slack-webhook/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-studio-api-token"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-studio-api-token/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-microsoft-client-secret"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-microsoft-client-secret/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-github-client-secret"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-github-client-secret/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-github-client-id"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-github-client-id/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-google-client-secret"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-google-client-secret/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-caller-principal"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-caller-principal/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-caller-hmac-key"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-caller-hmac-key/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-better-auth-secret"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-better-auth-secret/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-turnstile-secret-key"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-turnstile-secret-key/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-microsoft-client-id"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-microsoft-client-id/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-datasets-pin-principal"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-datasets-pin-principal/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-mcp-api-token"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-mcp-api-token/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-google-client-id"]: Refreshing state... [id=projects/dev-fin-observatory/secrets/dfo-dev-website-staging-google-client-id/roles/secretmanager.secretAccessor/serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com]
google_sql_provision_script.website_db_schema_grant: Refreshing state... [id=dev-fin-observatory/dfo-dev-platform-postgres]
google_sql_provision_script.website_db_acl: Refreshing state... [id=dev-fin-observatory/dfo-dev-platform-postgres]
google_sql_provision_script.website_export_reader: Refreshing state... [id=dev-fin-observatory/dfo-dev-platform-postgres]
google_sql_provision_script.website_export_reader_schema: Refreshing state... [id=dev-fin-observatory/dfo-dev-platform-postgres]
module.psc_network.google_compute_network.this: Refreshing state... [id=projects/dev-fin-observatory/global/networks/dfo-dev-website-psc]
module.psc_network.google_compute_subnetwork.this: Refreshing state... [id=projects/dev-fin-observatory/regions/northamerica-northeast1/subnetworks/dfo-dev-website-psc-subnet]
module.psc_network.google_dns_managed_zone.psc: Refreshing state... [id=projects/dev-fin-observatory/managedZones/dfo-dev-website-psc-sql]
module.psc_network.google_compute_address.psc_endpoint: Refreshing state... [id=projects/dev-fin-observatory/regions/northamerica-northeast1/addresses/dfo-dev-website-psc-endpoint]
google_cloud_run_v2_job.website_migrate: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/jobs/dfo-dev-website-staging-migrate]
google_cloud_run_v2_job.website_share_migrate: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/jobs/dfo-dev-website-staging-share-migrate]
module.website_service.google_cloud_run_v2_service.this: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/services/dfo-dev-website-staging]
module.psc_network.google_dns_record_set.psc: Refreshing state... [id=projects/dev-fin-observatory/managedZones/dfo-dev-website-psc-sql/rrsets/bbd723248b19.3niso0mm9bket.northamerica-northeast1.sql.goog./A]
module.psc_network.google_compute_forwarding_rule.psc_endpoint: Refreshing state... [id=projects/dev-fin-observatory/regions/northamerica-northeast1/forwardingRules/dfo-dev-website-psc-fwd]
google_cloud_run_v2_job_iam_member.website_share_migrate_deployer_run_developer: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/jobs/dfo-dev-website-staging-share-migrate/roles/run.developer/serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com]
google_cloud_run_v2_job_iam_member.website_migrate_deployer_run_developer: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/jobs/dfo-dev-website-staging-migrate/roles/run.developer/serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com]
module.website_service.google_cloud_run_v2_service_iam_member.public[0]: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/services/dfo-dev-website-staging/roles/run.invoker/allUsers]
module.website_service.google_cloud_run_v2_service_iam_member.deployer_run_developer["serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com"]: Refreshing state... [id=projects/dev-fin-observatory/locations/northamerica-northeast1/services/dfo-dev-website-staging/roles/run.developer/serviceAccount:dfo-website-staging-deployer@dev-fin-observatory.iam.gserviceaccount.com]
ephemeral.random_password.website_better_auth_secret: Closing...
ephemeral.random_password.website_better_auth_secret: Closing complete after 0s

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.website_service.google_cloud_run_v2_service.this has changed
  ~ resource "google_cloud_run_v2_service" "this" {
        id                      = "projects/dev-fin-observatory/locations/northamerica-northeast1/services/dfo-dev-website-staging"
        name                    = "dfo-dev-website-staging"
        # (36 unchanged attributes hidden)

      ~ template {
            # (11 unchanged attributes hidden)

          ~ containers {
              ~ image          = "northamerica-northeast1-docker.pkg.dev/dev-fin-observatory/dfo-website-staging/dfo-website@sha256:bbd394c81c42f81960906c4e2660d57847a63fb0ce38bf248807943b32deef4e" -> "northamerica-northeast1-docker.pkg.dev/dev-fin-observatory/dfo-website-staging/dfo-website@sha256:db11d1bb8032cf9435cbbc9fe4415cf7b01509a551aaa04a8b660f5841ce102d"
                name           = null
                # (6 unchanged attributes hidden)

                # (34 unchanged blocks hidden)
            }

            # (2 unchanged blocks hidden)
        }

        # (2 unchanged blocks hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # google_secret_manager_secret.website_admin_emails will be created
  + resource "google_secret_manager_secret" "website_admin_emails" {
      + create_time           = (known after apply)
      + deletion_policy       = "DELETE"
      + deletion_protection   = false
      + effective_annotations = (known after apply)
      + effective_labels      = {
          + "goog-terraform-provisioned" = "true"
        }
      + expire_time           = (known after apply)
      + id                    = (known after apply)
      + name                  = (known after apply)
      + project               = "dev-fin-observatory"
      + secret_id             = "dfo-dev-website-staging-admin-emails"
      + terraform_labels      = {
          + "goog-terraform-provisioned" = "true"
        }

      + replication {
          + auto {
            }
        }
    }

  # google_secret_manager_secret_version.website_admin_emails_placeholder will be created
  + resource "google_secret_manager_secret_version" "website_admin_emails_placeholder" {
      + create_time            = (known after apply)
      + deletion_policy        = (known after apply)
      + destroy_time           = (known after apply)
      + enabled                = true
      + id                     = (known after apply)
      + name                   = (known after apply)
      + project                = (known after apply)
      + secret                 = (known after apply)
      + secret_data            = (sensitive value)
      + secret_data_wo         = (write-only attribute)
      + secret_data_wo_version = 0
      + version                = (known after apply)
    }

  # module.website_service.google_cloud_run_v2_service.this will be updated in-place
  ~ resource "google_cloud_run_v2_service" "this" {
        id                      = "projects/dev-fin-observatory/locations/northamerica-northeast1/services/dfo-dev-website-staging"
        name                    = "dfo-dev-website-staging"
        # (36 unchanged attributes hidden)

      ~ template {
          ~ annotations                      = {
              - "readiness-dependencies" = "projects/41292283861/secrets/dfo-dev-website-staging-turnstile-secret-key/versions/1"
            } -> (known after apply)
            # (10 unchanged attributes hidden)

          ~ containers {
                name           = null
                # (7 unchanged attributes hidden)

              + env {
                  + name  = "ADMIN_EMAILS"
                    # (1 unchanged attribute hidden)

                  + value_source {
                      + secret_key_ref {
                          + secret  = "dfo-dev-website-staging-admin-emails"
                          + version = "latest"
                        }
                    }
                }

                # (34 unchanged blocks hidden)
            }

            # (2 unchanged blocks hidden)
        }

        # (2 unchanged blocks hidden)
    }

  # module.website_service.google_secret_manager_secret_iam_member.runtime_secret_access["dfo-dev-website-staging-admin-emails"] will be created
  + resource "google_secret_manager_secret_iam_member" "runtime_secret_access" {
      + etag      = (known after apply)
      + id        = (known after apply)
      + member    = "serviceAccount:dfo-dev-website-staging-run@dev-fin-observatory.iam.gserviceaccount.com"
      + project   = (known after apply)
      + role      = "roles/secretmanager.secretAccessor"
      + secret_id = "dfo-dev-website-staging-admin-emails"
    }

Plan: 3 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "tfplan"

Stack website · 488511f · @sefk · run

This branch was successfully deployed

1 active deployment
dev-plan — 488511f8 Deployed Nov 16, 2026 by sefk via plan (website) #274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant