Repository navigation
fix(ffi): return the error when online encryptor creation fails - #429
Merged
Mathieu Morrissette (mmorrissette-devolutions) merged 1 commit intoNov 20, 2026
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the FFI encryptor error-handling change.
No open issues 🎉
What changed in this PR
Fixes error handling in the FFI’s NewOnlineEncryptor so creation failures return an error code, matching NewOnlineDecryptor.
Changes:
- Returns constructor errors before allocating or assigning an encryptor handle.
- Adds a regression test checking that an unsupported public key produces a negative error code and leaves the handle null.
| File | Description |
|---|---|
ffi/src/lib.rs |
Propagates encryptor creation errors and adds regression coverage. |
Review effort: Balanced
Sébastien Duquette (sduquette-devolutions)
approved these changes
Nov 20, 2026
Mathieu Morrissette (mmorrissette-devolutions)
merged commit Nov 20, 2026
36e7d14
into
master
34 of 35 checks passed
Mathieu Morrissette (mmorrissette-devolutions)
deleted the
fix/ffi-online-encryptor-error
branch
November 20, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewOnlineEncryptornow returns the error code when the encryptor cannot be created, asNewOnlineDecryptordoes, instead of returning 0. Adds a test.