Repository navigation
build(dgw): use published cadeau 0.5.4 - #2183
Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 2 commits intoNov 6, 2026
Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 2 commits into
irvingouj@Devolutions (irvingoujAtDevolution) merged 2 commits into
Conversation
irvingouj@Devolutions (irvingoujAtDevolution)
added this pull request to stack #2184
November 4, 2026 19:36
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-dedup-cadeau-0.5.4
branch
4 times, most recently
from
November 5, 2026 21:01
88bdc70 to
e9fa56c
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
marked this pull request as ready for review
November 5, 2026 21:02
irvingouj@Devolutions (irvingoujAtDevolution)
requested review from
Benoît Cortier (CBenoit)
and
a balanced review from Copilot
and removed request for
Copilot
November 5, 2026 21:02
Copilot started reviewing on behalf of
irvingouj@Devolutions (irvingoujAtDevolution)
November 5, 2026 21:54
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the migration from temporary Git patches to published cadeau and xmf-sys releases.
No open issues 🎉
What changed in this PR
Replaces the temporary cadeau Git patches from #2060 with published crates, preserving the VPX encoder quantizer support used for recording compaction.
Changes:
- Updates Gateway and video-streamer to cadeau 0.5.4.
- Removes the cadeau and xmf-sys Git overrides.
- Locks registry releases cadeau 0.5.4 and xmf-sys 0.4.3 with checksums.
No findings were identified.
| File | Description |
|---|---|
devolutions-gateway/Cargo.toml |
Updates cadeau to 0.5.4, retaining dlopen. |
crates/video-streamer/Cargo.toml |
Updates cadeau to 0.5.4, retaining dlopen. |
Cargo.toml |
Removes temporary cadeau and xmf-sys Git patches. |
Cargo.lock |
Records published versions, registry sources, and checksums. |
Review effort: Balanced
The quantizer cap needs XmfVpxEncoder_CreateEx, which ships starting with cadeau v2026.10.26.0. XMF resolves every symbol at load, so the older native library would fail init and disable all video processing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cadeau 0.5.4 ships the VPX encoder quantizer range that recording compaction needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
feat/recording-dedup-cadeau-0.5.4
branch
from
November 6, 2026 19:29
2f79da9 to
d1e7950
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
deleted the
feat/recording-dedup-cadeau-0.5.4
branch
November 6, 2026 19:30
irvingouj@Devolutions (irvingoujAtDevolution)
restored the
feat/recording-dedup-cadeau-0.5.4
branch
November 6, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches #2060 from the git patch on cadeau
e56c47cto the published crates: cadeau 0.5.4 / xmf-sys 0.4.3 (cadeau#88), which carry the VPX encoder quantizer range. Pairs with the XMF nativev2026.10.26.0pin in #2060.🤖 Generated with Claude Code