Repository navigation
fix(installer): stop granting Users read access to the data folder - #2190
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the data-folder access restriction and its associated regression coverage.
No open issues 🎉
What changed in this PR
Restricts access to Gateway’s data folder to SYSTEM, administrators, and the service account, protecting recordings and private keys from non-admin users.
Changes:
- Removes the
BUILTIN\Usersread-access entry from the data-folder security template and updates its documentation. - Adds regression coverage checking allowed readers for the data-folder and users-database templates.
| File | Description |
|---|---|
package/WindowsManaged/Resources/Includes.cs |
Removes Users read access and documents the restricted permissions. |
package/WindowsManaged.UnitTests/DataFolderTests.cs |
Verifies that only SYSTEM, administrators, and the service account receive read access. |
Review effort: Balanced
d00546f to
3b02b7a
Compare
The installer gave BUILTIN\Users read access to %ProgramData%\Devolutions\Gateway, and everything the Gateway stores there inherited it. Only SYSTEM, administrators and the service account now get access. Install, upgrade and repair already reset the data folder's DACL and the entries below it, so existing files lose the entry on upgrade. Issue: DGW-504 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3b02b7a to
17fbb5a
Compare
ebbaff8
into
master
The installer gave
BUILTIN\Usersread access to%ProgramData%\Devolutions\Gateway, and everything in it inherits that, including recordings andserver.key. Only SYSTEM, admins and the service account need it, so this drops the Users entry fromPROGRAM_DATA_SDDL_TEMPLATE.Existing installs get fixed on upgrade: install/upgrade/repair already reset the DACL of the folder and everything below it.
Heads-up: non-admins can't read
gateway.jsonor the logs anymore.Tested
DataFolderTests.OnlySystemAdministratorsAndTheServiceAccountCanReadTheData(red before, green after), full installer unit tests pass.server.key. The service still writes recordings and serves them through/jet/jrec/pull, and admins can still read/write.Issue: DGW-504
🤖 Generated with Claude Code