Repository navigation
The net zone's supplicant takes no DPP frames, which any radio in range could send it unassociated - #325
Merged
Conversation
…ge could send it unassociated wpa_supplicant was built with CONFIG_DPP. Built so, a station registers for DPP's public action frames and for GAS's (driver_nl80211.c, nl80211_mgmt_subscribe_non_ap), and wpas_dpp_rx_action parses every DPP frame's attributes before it finds no provisioning under way. Any radio in range can send those frames to the net zone's address unassociated, and nothing in Kryptik provisions networks by DPP: kryptik wifi add takes an SSID and a passphrase. The recipe now builds without DPP. The zones suite checks that the image's supplicant carries none of DPP's control commands, which a DPP build holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
build/recipes/wpa-supplicant.shbuilt the net zone'swpa_supplicantwithCONFIG_DPP=y. Built that way, the station registers with the kernel for DPP's public action frames, and for GAS's initial and comeback frames, at start (nl80211_mgmt_subscribe_non_apin hostap 2.12'ssrc/drivers/driver_nl80211.c).When a DPP frame arrives,
wpas_dpp_rx_action(wpa_supplicant/dpp_supplicant.c) parses its attributes withdpp_check_attrsand dispatches on its type. Only after that does it find that no provisioning is under way. Any radio in range can send those frames to the net zone's address without associating.Nothing in Kryptik provisions networks by DPP:
kryptik wifi addtakes an SSID and a passphrase.What changed
docs/design/net-zone.md: the wireless uplinks list says the supplicant takes no provisioning frames.docs/design/net-zone-surface.md: its line references into the recipe follow the change.How the run proves it
The zones suite has a new
wifi-no-dppcheck. It passes when/usr/sbin/wpa_supplicantcontains none of DPP's control command strings (DPP_BOOTSTRAP_GEN,DPP_LISTEN). A DPP build always contains them, so the check fails on the old image.The existing checks show that Wi-Fi still works the same way:
wifi-ap(the suite's access point is this binary in AP mode),wifi-associated,wifi-lease,wifi-egressandradio-recarried.This is a recipe change, so the Distro run rebuilds the supplicant's step.