Repository navigation
Avoid redundant tokenizer buffer checks - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokenizer calls
ensureBuffer()while skipping whitespace and again before reading the next token, even when the current byte is already available.This adds a direct check in
skipWhitespace()andnextToken()soensureBuffer()is only called when the current byte is missing. Both methods retain their existing read attempts, including the retry when the stream temporarily returns no data.The following benchmarks compare this change against the implementation after #203, using PHP 8.4.27 and 35,798 synthetic responses per workload. Each result is the average CPU time across six runs.
All 924 unit tests pass, and 3,125 comparisons against the previous tokenizer produced matching token and exception results.
Refs #200.