Repository navigation
Index FETCH fields in a single pass - #207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating messages from FETCH responses currently scans each response six times to find its UID, size, flags, headers, body, and body structure. Each lookup converts the tokens it passes to strings, which can repeatedly rebuild large body strings and nested lists.
This indexes field names and BODY sections in a single pass, then reads the required fields from that index. Literal contents and nested lists are skipped during indexing. Duplicate fields continue to use the first occurrence, and missing fields retain their existing defaults.
The following benchmarks compare this change against the implementation after #206 on PHP 8.4.27, with CLI OPcache and JIT disabled. Each value is the median of six alternating samples, with each sample averaging 20 executions after a warm-up.
These measurements exercise
get()with prepared SEARCH and FETCH responses, covering local UID processing, field extraction, and message construction. Response parsing, network time, and the connection's FETCH-response filtering are excluded. Every sample verified the returned message count, UIDs, flags, sizes, headers, and bodies.All 1,046 unit tests pass.
Refs #200.