Repository navigation
Prevent IMAP command injection in UID values and message flags - #208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caller-supplied UID values and message flags can currently include line breaks that introduce additional IMAP commands. Applications that pass user input into these APIs can allow commands to execute in their authenticated mailbox session.
This validates sequence sets before they are used in queries and validates flags before sending STORE or APPEND commands. Command compilation also rejects control characters in command names, tags, and non-literal tokens before any data is written to the connection. Literal message content continues to support line breaks.
The assertions live in
Support\Assert, withhasNoControlCharacters(),isValidFlag(), andisValidSequenceSet()methods. Invalid input throwsInvalidArgumentException.Verified with the full suite against a local GreenMail server. All 1,185 tests pass.