Fix rimport empty warning order - #34
Merged
Merged
Conversation
Fails today: the "no files found" warning is logged inside the walk loop, so it prints above the expansion count, while the skip warning from the same function prints below it. Pins the whole order below the count -- count, then empties, then skips -- and the indent that marks both warnings as subordinate to the count. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
expand_directories() collects the empty directories during the walk and reports them where the skip warnings are already reported, after the count. Both warnings now sit below the count and are indented under it; the emptiness warning's text is otherwise unchanged. Presentation only. Entries, skips, counts and exit codes are untouched. Verified: full pytest suite green, and the reproduction from the issue report run by hand. Resolves ESMCI#33. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The ordering test's docstring said both warnings below the count are indented, but only the emptiness half was asserted; dropping INDENT from the skip warning left the suite green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The count line and the skips were already pinned against a directory named twice; the emptiness warning was not, and both existing duplicate tests use a non-empty directory, so removing the dedup left it uncaught. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 99.31% 99.32%
=======================================
Files 31 31
Lines 4243 4270 +27
=======================================
+ Hits 4214 4241 +27
Misses 29 29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #33.