Skip to content

fix(clone): no quadratic check of proved lemmas in theory overrides #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strub merged 1 commit into from
Oct 14, 2026
Merged

fix(clone): no quadratic check of proved lemmas in theory overrides #1208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/ecThCloning.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,16 @@ end = struct
in { evc with evc_ths = ths })
nm evc in

(* The lemmas that already have a proof *)
let proved : (qsymbol, unit) Hashtbl.t =
let proved = Hashtbl.create 0 in
List.iter (fun prf ->
match prf.pthp_mode with
| `Named (y, _) -> Hashtbl.replace proved (unloc y) ()
| `All _ -> ())
proofs;
proved in

(* A more specific override takes precedence over the one implied
* by the theory override. *)
let overridden (prefix : symbol list) (dth : theory_item_r) =
Expand All @@ -558,10 +568,7 @@ end = struct
|> obind (fun (sub, _) -> sub.evc_target)
|> is_some
| Th_axiom (x, _) ->
List.exists (fun prf ->
match prf.pthp_mode with
| `Named (y, _) -> unloc y = (xdth @ prefix, x)
| `All _ -> false) proofs
Hashtbl.mem proved (xdth @ prefix, x)
| _ -> false in

let rec doit_r (prefix, tgprefix) (proofs, evc) dth =
Expand Down
Loading