Skip to content

regulated_pp: do not count passing above or below the goal as reaching it - #179

Merged
fmrico merged 1 commit into
EasyNavigation:rollingfrom
jmguerreroh:pr-regulated-pp
Nov 6, 2026
Merged

fmrico merged 1 commit into
EasyNavigation:rollingfrom
jmguerreroh:pr-regulated-pp

Conversation

@jmguerreroh

Copy link
Copy Markdown
Contributor

Split out of #177, as suggested.

What

In buildings with floors over each other, the robot can pass right above or below the goal (for example on the floor over it, on its way down). RegulatedPurePursuitController only compared the x, y distance, so it considered the goal reached there and started aligning to the goal heading.

It now also checks the height, using goal_tolerance.height from the NavState (the GoalManager's tolerance):

  • If goal_tolerance.height is not in the NavState, the height is ignored, as before.
  • Its default is 10000 m, so the behaviour only changes when a height tolerance is configured.

The change is in update_rt (on_goal_floor).

Tests

New cases in regulated_pp_goal_approach_tests.cpp.

@jmguerreroh
jmguerreroh requested a review from Butakus November 5, 2026 09:30
@jmguerreroh jmguerreroh added the bug Something isn't working label Nov 5, 2026
@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jmguerreroh
jmguerreroh requested a review from fmrico November 5, 2026 11:12
@fmrico

fmrico commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

LGTM!! Merging 🚀

@fmrico
fmrico merged commit eee8508 into EasyNavigation:rolling Nov 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants