Repository navigation
regulated_pp: do not count passing above or below the goal as reaching it - #179
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
LGTM!! Merging 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #177, as suggested.
What
In buildings with floors over each other, the robot can pass right above or below the goal (for example on the floor over it, on its way down).
RegulatedPurePursuitControlleronly compared the x, y distance, so it considered the goal reached there and started aligning to the goal heading.It now also checks the height, using
goal_tolerance.heightfrom the NavState (the GoalManager's tolerance):goal_tolerance.heightis not in the NavState, the height is ignored, as before.The change is in
update_rt(on_goal_floor).Tests
New cases in
regulated_pp_goal_approach_tests.cpp.