Repository navigation
Conversation
updateEslintWarnings.ts removed a committed file from every list in eslint.config.mjs. Committing VectorIcon.tsx therefore also dropped it from the shared icon wrappers' import exemption. Limit the removal to the warnings list.
WalletListMenuModal passes the AntDesign font's iOS name, anticon, to VectorIcon. The icon library names fonts by file on Android, so the lookup missed and the rows rendered blank. Accept either name on either platform, and render with the current platform's name.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
commented
Oct 30, 2026
j0ntz
left a comment
j0ntz
left a comment
Contributor
Author
There was a problem hiding this comment.
Fixed before review (1)
src/__tests__/components/VectorIcon.test.tsx: untypedanyfor the rendered test output. Folded into "Fix wallet menu icons missing on Android".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
On Android 4.52.2, every row of the wallet options sheet except Wallet Settings shows a blank space where its icon belongs. iOS is fine.
7a2cbf14a moved
WalletListMenuModalto<VectorIcon font="anticon">to clear a lint warning.react-native-vector-iconsnames each font by family on iOS (anticon) and by file on Android (AntDesign). On Android the font lookup missed andVectorIcondrew an empty glyph.VectorIconnow accepts either name on either platform and renders with the name the current platform uses. The modal keeps rendering throughVectorIcon, which preserves the lint goal of that commit. Six fonts have differing names (AntDesign, Foundation, MaterialCommunityIcons, MaterialIcons, SimpleLineIcons, Zocial), and all six are covered.The first commit fixes
scripts/updateEslintWarnings.ts. It removed a committed file from every list ineslint.config.mjs, which would have droppedVectorIcon.tsxfrom the icon wrappers' import exemption on commit. The script now touches only the warnings list.The CHANGELOG entry sits under a new undated
## 4.52.3section because the task targets that release./point-releaseexpects GUI entries under## Unreleased (develop)and writes the dated section itself. A point release needs this section moved to Unreleased first, or develop ends up with two 4.52.3 sections.Tested on an iOS simulator and an Android emulator, not on physical devices. The BTC wallet options sheet shows an icon on all eight rows on both.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
3c5d1ccFix wallet menu icons missing on Android
2026-10-30
2. ios wallet options icons
3. android wallet options icons