Repository navigation
Conversation
Swap react-native-zcash 0.13.6 for zcash-native. This is the Zcash part of 661f308 on paul/nodePlugins; Monero and Zano stay on that branch. Pins zcash-native 0.1.0 and edge-currency-accountbased 4.104.0, the next versions those packages publish. Install fails until they do.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1 of 2 tasks
j0ntz
added
the
awaiting-dep-publish
j0ntz
commented
Oct 31, 2026
j0ntz
left a comment
j0ntz
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review with code-review-sonnet at medium on develop..19902ca55 reported 2 findings, and curation rejected both.
Rejected in curation (2)
package-lock.json:128: the lockfile does not match whatnpm cican resolve. Rejected: the two pinned versions publish at landing, and the version bump at landing regenerates the lockfile.ios/Podfile.lock:2777: thezcash-nativeandedge-currency-accountbasedchecksums come from local builds. Rejected as a code change: this is real and belongs to the landing bump, which regenerates them. The PR body states it.
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Replaces
react-native-zcash0.13.6 withzcash-native, the Zcash part of 661f308 onpaul/nodePlugins, and movesedge-currency-accountbasedto the version that uses it. Monero and Zano stay where they are. No app source changes.The native library comes from the NU7 zingolib base on EdgeApp/zcash-native#1.
ios/Podfile.lockloses the Swift gRPC pods the old SDK needed. Its checksums forzcash-nativeandedge-currency-accountbasedcome from local builds and get regenerated with the version bump at landing.Testing
Unit tests pass (
verify-repo --skip-install). iOS and Android debug builds pass, withzcash-nativeandedge-currency-accountbasedlinked locally.e6e0fd574afebf755c6c63f6ce90433874d07efba15254025f177343698d6f0990913d738d6d1f5851dc4e38656356450dda31bef95e4a88eac0bbc6d219322eTest-only setup: the TAZ wallets need the testnet plugin from EdgeApp/edge-currency-accountbased#1128 and EdgeApp/edge-react-gui#6282 plus a local
corePlugins.zcashtestnetsetting. Neither is in this PR.Frames 01 to 15 ran with
zcash-nativeat 473030b. Frames 16 to 18 are the re-check without a send on the final head, which differs only in a poll error branch. Frame 19 is the wallet during the change-only count on the final head, where the real change was a Node entry send,04e1472d745cb4279fc80296081748c02588ae804f14cfba35710ead82de5be3. It did not produce a second balance callback at its block confirmation within the 13 minutes watched.Not exercised: the 32-bit Android library on a device, shielding and Orchard-to-Ironwood, and two wallet folders in one process.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
zcash-native0.1.0edge-currency-accountbased4.104.0CI fails at install until both versions are on npm.
Requirements
If you have made any visual changes to the GUI. Make sure you have:
No visual changes.
Awaiting publish: edge-currency-accountbased@4.104.0 (npm latest when applied: 4.103.0)
Awaiting publish: zcash-native@0.1.0 (npm latest when applied: 0.0.1)
Test evidence
19902caMove Zcash to zcash-native
2026-10-31
1. bad testnet address rejected
2. mainnet address routes to zec swap
3. testnet transparent accepted
4. testnet tex accepted
5. testnet unified accepted
6. testnet sapling accepted
7. taz send ready to confirm
8. taz send transaction success
9. mainnet zec wallet open
10. android testnet wallet
11. android bad testnet address rejected
12. android testnet sapling accepted
13. android taz send ready to confirm
14. android taz send transaction success
15. android mainnet zec wallet open
16. ios taz wallet on fix head
17. ios mainnet zec wallet on fix head
18. android taz wallet on fix head
19. ios taz wallet change only probe