Repository navigation
Use separate POM files for core and monkey artifacts - #13
Open
jaime-jmebot wants to merge 1 commit into
Open
jaime-jmebot wants to merge 1 commit into
jaime-jmebot wants to merge 1 commit into
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both publications write their generated metadata to
jector.pom. Generating the monkey POM overwrites the core POM before the publishing step.Change
Use
jector-monkey.pomfor the monkey artifact and add a regression check for distinct, correctly named POM paths.Validation
python3 helper-scripts/tests/check-pom-paths.py: fails on upstreambdca41a, passes with this fixsh -n helper-scripts/project-impl/variables.shandgit diff --check: passSigning and artifact publication were not performed. Existing published metadata would require a new release.
Supersedes #12 with the same fix submitted from the project bot account.
This automated PR is part of the jMonkeyEngine community library quality check.