Repository navigation
[Docker] Use the npm bundled with Node 20 - #11
Merged
Merged
Conversation
noobHappylife
marked this pull request as ready for review
November 18, 2026 04:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The source image build installs Node 20, then upgrades npm to
latest. That now selects npm 12.2.3, which requires Node 22.22.2 or newer, so the image fails before building the dashboard.Use the npm already bundled with Node 20. This removes the unnecessary upgrade without changing the Node runtime or SkyPilot code.
Test plan
EBADENGINEwith the existing Dockerfile: Node 20.20.2 and npm 12.2.3.v0.12.0-ellm.20261118.3image also passed API health, dashboard delivery, and a queued SDK status request after the separate constructor fix in [API] Remove unsupported FastAPI application prefix #12.git diff --checkis clean. This changes only the Dockerfile; no new test file.