Repository navigation
[Kubernetes] Keep the upstream-supported client bound - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh API-server images resolve Kubernetes client 37.0.1. Its generated model type strings use
Dict[str, str], which this fork's pod-config validator treats as a model name. Controller provisioning then repeatedly fails before creating a pod:Use the same
kubernetes<36.0.0compatibility bound declared by upstream SkyPilot 0.14.2 and 0.14.3. Keep the existing exclusion of 32.0.0. This avoids changing the validator to accommodate an otherwise unqualified generated-client API.Test plan
git diff --checkpassed. The unmodified.4release image passed a fresh SDK -> API -> Kubernetes controller launch, all seven Ray bootstrap patches, controller readiness with zero restarts, and a real Ray remote task returning 3. Its API image resolves client 35.0.0. TokenVisor pins are updated to.4for the next CI run.