Fix review findings and add regression tests - #1
Merged
Merged
Conversation
Endogen
force-pushed
the
review/fix-bugs-1-10
branch
from
September 21, 2026 22:48
dbb9d8c to
6888490
Compare
- Fix MCP tool resolution for slugs/endpoints containing underscores - Enforce only/exclude filters on filtered MCP call routes - Support optional next-page selector for param-based pagination - Coerce non-scalar scraped fields to JSON strings - Invalidate response cache on recipe install/update/uninstall - Add explicit catalog trust default (untrusted) via catalog_entry_is_trusted - Guard _build_error_response against unknown endpoints - Move status_code_for_error to schemas and reuse it in the MCP bridge - Honor the page parameter in MCP bridge and protocol tools - Map MCP tool errors to proper HTTP status codes - Add InvalidParamsError + coerce_int/coerce_float scraper helpers - Map InvalidParamsError to INVALID_PARAMS in the scraping engine - Remove dead fetch_remote_tree_hash helper - Use File(default=None) for the upload route Add tests for coercion helpers, status mapping, MCP tool resolution, and MCP bridge routes (page passthrough, filtered enforcement, error status).
Endogen
force-pushed
the
review/fix-bugs-1-10
branch
from
September 21, 2026 22:52
6888490 to
2bd018a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes identified during a code review of
web2api+web2api-recipes, plus regression tests.Bugs fixed
_(matches viabuild_tool_nameinstead of string-splitting).only/exclude(previously ignored).selectorfor accuratehas_next.catalog_entry_is_trusted(shared by CLI + API)._build_error_responseguards against unknown endpoints.status_code_for_errormoved toschemas.py).pageparameter is now honored in both the HTTP bridge and protocol tools.InvalidParamsErrormaps toINVALID_PARAMS; scrapers usecoerce_int/coerce_float.fetch_remote_tree_hash, switched upload route toFile(default=None).Tests
test_scraper.py,test_schemas.py,test_mcp_bridge.py,test_mcp_bridge_routes.py; extendedtest_mcp_server.py.Companion recipes changes: Endogen/web2api-recipes#1