[tsmbland]

Description

Similar to #1547, but doesn't require/allow users to manually mark feedback processes. These are detected based on which commodities end up out of order in the MILP result, with an added constraint to make sure that the system remains valid once feedback processes are removed (necessary for the second investment pass). I imagine this PR is the one we'll merge over #1547, if this two-pass approach proves useful, but that other PR is useful for testing different feedback_process configurations.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change to fix an issue)
• New feature (non-breaking change to add functionality)
• Refactoring (non-breaking, non-functional change to improve maintainability)
• Optimization (non-breaking change to speed up the code)
• Breaking change (whatever its nature)
• Documentation (improve or add documentation)

Key checklist

• All tests pass: $ cargo test
• The documentation builds and looks OK: $ cargo doc
• Update release notes for the latest release if this PR adds a new feature or fixes a bug
  present in the previous release

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite	Current: 948f1b7	Previous: 6a19604	Ratio
select_best_assets_parallel/01	13564670.46875 ns	9132896.765151516 ns	1.49
select_best_assets_parallel/05	38101280.5 ns	26819628.777777776 ns	1.42
select_best_assets_parallel/10	64754173 ns	45113674.75 ns	1.44
select_best_assets_parallel/15	94518125.75 ns	65351435.33333333 ns	1.45
select_best_assets_parallel/20	124836132.25 ns	85097739.5 ns	1.47
select_best_assets_sequential/01	13319748.961538462 ns	9107675.635526314 ns	1.46
select_best_assets_sequential/05	64110279.33333333 ns	43859325.75 ns	1.46
select_best_assets_sequential/10	127960637.5 ns	87553632.5 ns	1.46
select_best_assets_sequential/15	192535830.5 ns	131658938.5 ns	1.46
select_best_assets_sequential/20	259066737 ns	175652280.5 ns	1.47

This comment was automatically generated by workflow using github-action-benchmark.

[Copilot]

🟡 Changes recommended

Unresolved feedback-ordering, demand-accounting and input-handling bugs can cause infeasible portfolios, unnecessary investment and model-loading panics.

5 open issues

• Include OTH-node supplies in external supply analysis · New
• Return an error for cycles without external supply · New
• Ensure each market retains a valid primary producer · New
• Preserve signed flow balances across updates · New
• Classify feedback for eligible existing assets · New

What changed in this PR

This PR replaces MUSE2’s flexible-capacity cycle balancing with a two-pass investment algorithm that detects feedback processes automatically, unlike the manual configuration approach in #1547.

Changes:

• Adds supply-preservation constraints to cycle ordering and automatic feedback exclusion during the second investment pass.
• Passes explicit demand maps into dispatch and removes capacity_margin.
• Combines regional commodity graphs into yearly graphs and updates circularity regression expectations.

File	Description
tests/​data/​circularity/​commodity_prices.csv	Updates expected circularity prices.
tests/​data/​circularity/​assets.csv	Updates expected selected assets.
tests/​data/​circularity/​asset_capacities.csv	Updates expected capacities and tranche counts.
tests/​data/​circularity_npv/​commodity_prices.csv	Updates expected NPV scenario prices.
tests/​data/​circularity_npv/​assets.csv	Updates NPV scenario asset selections.
tests/​data/​circularity_npv/​asset_capacities.csv	Updates NPV scenario capacities.
tests/​cli.rs	Checks the yearly graph filename.
src/​simulation/​optimisation/​constraints.rs	Uses explicit demands and removes flexible-capacity constraints.
src/​simulation/​optimisation.rs	Accepts demand maps and removes capacity decision variables.
src/​simulation/​market.rs	Implements feedback detection and two-pass investment.
src/​simulation/​investment.rs	Supplies dispatch demands and introduces demand flooring.
src/​simulation.rs	Passes preset demands to final dispatch.
src/​model/​parameters.rs	Removes capacity_margin.
src/​input.rs	Loads yearly graphs and propagates ordering errors.
src/​graph/​validate.rs	Validates region-aware nodes and edges.
src/​graph/​investment.rs	Adds external-supply tracking and cycle-order constraints.
src/​graph.rs	Builds and exports one region-aware graph per year.
schemas/​input/​model.yaml	Removes the capacity-margin schema entry.
benches/​assets.rs	Adapts benchmark dispatch to explicit demands.

_{Review effort: Balanced}