Repository navigation
Protect Java certificates after workstation setup - #10
Draft
roryabraham wants to merge 1 commit into
Draft
roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
Invoke the Toolkit certificate bootstrap after Ansible succeeds. Keep the normal user's terminal so individual privileged appends can request sudo independently of Ansible's become password. Mock the handoff to verify terminal/user preservation, checkout casing, paths with spaces, and failure propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Run the shared Java certificate protection bootstrap after the stage-two Ansible playbook succeeds. The call stays in the normal user's shell with its terminal, so the shared script can request sudo for individual protected-file appends independently of Ansible's become password.
bash "$HOME/Expensify-ToolKit/laptop-config/fixCACerts.sh"afteransible-playbook.Expensify-ToolKitcasing for Linux.Merge dependency: https://github.com/Expensify/Expensify-ToolKit/pull/205 must land first so the stage-two checkout contains the helper. That PR pins the shared script and certificate policy from Expensify/GitHub-Actions#117 and documents the one-time existing-employee rollout.
Fixed Issues
No separate issue supplied.
AI Tests
python3 -B -m unittest discover -s tests -v— one mocked test with three scenarios: success, Ansible failure, and certificate-step failure. Verifies execution order, normal-user identity, inherited terminal stdin, exact checkout casing, and a home path containing spaces. Ansible, the fixer, and terminal formatting are mocked; no installers or JVMs were run.bash -n bootstrap.sh.git diff --cached --check.check_supported_platform()line (SC1073/SC1064/SC1072); confirmed the same failure onorigin/mainatbbd7089cee97ae7a95072558217987ae49f28d57.Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.