Repository navigation
[No QA] Block compromised Java certificates in CI - #785
Closed
roryabraham wants to merge 1 commit into
Closed
roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
Apply the shared eMudhra certificate blocklist after Java setup and cache restoration, before Java network operations. Keep the selected JVM protected when nested Android actions would otherwise replace it. Source: Expensify/GitHub-Actions#117
Contributor
Author
|
Consolidated into #784; retaining that draft and preserving both branches and commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Block compromised eMudhra certificates in the selected Zulu 17 JVM immediately after Java setup, before npm installation or the Android Gradle build. Use the shared action from Expensify/GitHub-Actions#117 so cache hits are patched and verification failure stops the job.
Context: https://expensify.slack.com/archives/C0CAUQBC89F/p1792630445125879?thread_ts=1792538940.390139
AI Tests
git diff --check. Embedded shell/Python checks were disabled because their bodies are unchanged.Related Issues
For Expensify/GitHub-Actions#117
Manual Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Linked PRs
Expensify/GitHub-Actions#117 (merged shared action)