Repository navigation
Specify Modrinth dependency versions based on gradle.properties - #1319
Merged
Merged
Conversation
Robotgiggle
added
1.20
optimization
Robotgiggle
force-pushed
the
update-deps
branch
from
October 4, 2026 02:47
94a04dd to
e321a09
Compare
s5bug
requested changes
Oct 12, 2026
s5bug
left a comment
s5bug
left a comment
Contributor
There was a problem hiding this comment.
Afaict this technically bumps Patchouli which deserves a changelog entry imo.
Comment on lines
68
to
+80
| @@ -77,7 +77,7 @@ jobs: | |||
| 'https://cdn.modrinth.com/data/TZo2wHFe/versions/HyBiJPtT/paucal-0.6.0%2B1.20.1-forge.jar' | |||
| 'https://cdn.modrinth.com/data/fin1PX4m/versions/H1jsvy53/inline-forge-1.20.1-1.2.2.jar' | |||
| 'https://cdn.modrinth.com/data/40FYwb4z/versions/fs9CeXYZ/caelus-forge-3.1.0%2B1.20.jar' | |||
| 'https://cdn.modrinth.com/data/nU0bVIaL/versions/JMtc0mTS/Patchouli-1.20.1-84-FORGE.jar' | |||
| 'https://cdn.modrinth.com/data/nU0bVIaL/versions/94dtOLgZ/Patchouli-1.20.1-85-FORGE.jar' | |||
Contributor
There was a problem hiding this comment.
An action could be used to read the .properties and fetch the correct resources here too, right? Perhaps not fit for this PR, but I'm pretty sure you can have one step output some JSON and then a matrix that uses fromJSON for something.
Member
Author
There was a problem hiding this comment.
Currently I don't know nearly enough about github actions to set up something like that, so if it is possible it would definitely go in a different PR.
s5bug
approved these changes
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
modrinthDependenciessection of each platform'sbuild.gradleto specify versions based on the values ingradle.propertiesrather than hardcoding them. Notably, this fixes a mismatch between the version of Patchouli the mod actually depends on and the version specified as a dependency for Modrinth, which should resolve #1318.