Repository navigation
Proper generic type for component streamcodec buffer - #1332
Merged
Merged
Conversation
…specifying RegistryFriendlyByteBuf
Robotgiggle
added
optimization
IridescentVoid
approved these changes
Oct 14, 2026
IridescentVoid
left a comment
IridescentVoid
left a comment
Contributor
There was a problem hiding this comment.
It compiles and the change looks simple enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows image components to be specified with a StreamCodec that uses any subclass of ByteBuf, rather than specifically requiring one that uses RegistryFriendlyByteBuf. This allows defining components for a variety of simpler types that use FriendlyByteBuf or just plain ByteBuf in their stream codecs.