Skip to content

feat(Dependencies): Keep the staged changes footer in view - #8717

Open
talissoncosta wants to merge 2 commits into
feat/flag-dependencies-cr-pending-8450from
feat/flag-dependencies-cr-interactions-8450
Open

talissoncosta wants to merge 2 commits into
feat/flag-dependencies-cr-pending-8450from
feat/flag-dependencies-cr-interactions-8450

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #8450

The staged changes footer sticks to the bottom of the tab, so Create Change Request stays in reach on a long list. The unsaved changes prompt moved down to #8715.

How did you test this code?

Checked locally against main, which has #8720.

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Oct 16, 2026 8:11pm UTC
flagsmith-frontend-staging Ready Ready Preview Oct 16, 2026 8:11pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 16, 2026 8:11pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d0da5a4a-e4f9-4244-bd51-57b0e2fc594f
📥 Commits

Reviewing files that changed from the base of the PR and between 06e1f37 and 1d85d30.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a33ab6eb-e616-471b-b1a4-383bf6f85362
📥 Commits

Reviewing files that changed from the base of the PR and between d7ae5c5 and 06e1f37.

📒 Files selected for processing: 3
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/ChangeRequestFooter/ChangeRequestFooter.scss
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/ChangeRequestFooter/ChangeRequestFooter.tsx
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/ChangeRequestFooter/index.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

📝 Walkthrough

The change adds sticky positioning, bottom alignment, padding and a surface background to the change request footer. It adds a top border and stacking order, and announces the staged-change count through a polite live region. The create button retains its loading state but no longer receives an explicit disabled state while submitting. The module index now re-exports the component.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 06e1f

The staged-changes footer remains reachable while scrolling long dependency tabs, and the create button remains disabled during submission. No concrete merge-blocking risk was found.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Oct 9, 2026
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 9, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from 6ef828a to feaae05 Compare October 9, 2026 19:53
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 9, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from feaae05 to 819e381 Compare October 9, 2026 20:04
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 9, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from 819e381 to a3c25bc Compare October 9, 2026 20:58
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 9, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from 3dd4af9 to 3e1c107 Compare October 12, 2026 15:14
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 12, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from 3e1c107 to da8fc89 Compare October 12, 2026 17:26
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 12, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from da8fc89 to 3ca9c03 Compare October 12, 2026 17:29
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 12, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from 3ca9c03 to efd39ee Compare October 12, 2026 17:31
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 12, 2026
@talissoncosta
talissoncosta force-pushed the feat/flag-dependencies-cr-interactions-8450 branch from efd39ee to 9f3cad3 Compare October 12, 2026 17:36
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Oct 12, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-8717 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8717 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8717 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8717 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-8717 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8717 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8717 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8717 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8717 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22555 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 7 seconds
commit  1d85d30
info  🔄 Run: #22555 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-16 — run #22555 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  48 seconds
commit  1d85d30
info  🔄 Run: #22555 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22560 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  6 passed

Details

stats  6 tests across 6 suites
duration  53.3 seconds
commit  1d85d30
info  🔄 Run: #22560 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #22560 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  56.7 seconds
commit  1d85d30
info  🔄 Run: #22560 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #22560 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  36.8 seconds
commit  1d85d30
info  🔄 Run: #22560 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #22555 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  36.2 seconds
commit  1d85d30
info  🔄 Run: #22555 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #22555 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  31.9 seconds
commit  1d85d30
info  🔄 Run: #22555 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #22560 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  31.9 seconds
commit  1d85d30
info  🔄 Run: #22560 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22548 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  37.7 seconds
commit  06e1f37
info  🔄 Run: #22548 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #22549 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  36.3 seconds
commit  06e1f37
info  🔄 Run: #22549 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #22548 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  42.1 seconds
commit  06e1f37
info  🔄 Run: #22548 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #22549 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  34.9 seconds
commit  06e1f37
info  🔄 Run: #22549 (attempt 1)

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

24 screenshots compared. See report for details.
View full report

talissoncosta and others added 2 commits October 16, 2026 17:09
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The text sat on the edge of its background.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — 1d85d307 Deployed Oct 16, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — 1d85d307 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants